This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Rasterizer] Make resubmit information temporary #42001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
May 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 25, 2023
…127625) flutter/engine@99f2653...6a4e675 2023-05-25 [email protected] Roll Skia from e648bf802cd2 to bd677c195886 (2 revisions) (flutter/engine#42325) 2023-05-25 [email protected] [Rasterizer] Make resubmit information temporary (flutter/engine#42001) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dkwingsmt
added a commit
that referenced
this pull request
May 31, 2023
This reverts commit 9f36408.
dkwingsmt
added a commit
that referenced
this pull request
Jun 2, 2023
Reverts #42001 due to being the likely culprit to flakiness flutter/flutter#127936 .
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
Relands #42001. The previous attempt was reverted due to post-submit flakeness, some mysterious crashes. I didn't change anything this time, but now that PR #44973 is merged that fixes some racing issues, I wonder if the crashes of this change are resolved as well. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Relands flutter#42001. The previous attempt was reverted due to post-submit flakeness, some mysterious crashes. I didn't change anything this time, but now that PR flutter#44973 is merged that fixes some racing issues, I wonder if the crashes of this change are resolved as well. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
Rasterizerso that the resubmit information is returned as a temporary struct instead of stored permanently as class member. This limits the lifetime of these values and reduces class members.Additionally, this benefits the multi-view project: if the rasterizer is going to store multiple surfaces, what variables should be stored in a map from view IDs? Should all surfaces have a to-be-submitted record? The answer is "no", because these information is only temporary.
This PR should not need unit tests since it's only a refactor.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.