This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS - TextInput] Insert new line only when TextInputAction.newline #41977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
approved these changes
May 12, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thanks for testing both cases.
bleroux
added
the
autosubmit
bleroux
deleted the
macos_text_input_insert_new_line_only_for_input_action_newline
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2023
…126735) flutter/engine@eb57481...259daf6 2023-05-13 [email protected] [macOS - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#41977) 2023-05-13 [email protected] Roll Skia from cfdfc039b848 to 872787e7595c (1 revision) (flutter/engine#42010) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#126735) flutter/engine@eb57481...259daf6 2023-05-13 [email protected] [macOS - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#41977) 2023-05-13 [email protected] Roll Skia from cfdfc039b848 to 872787e7595c (1 revision) (flutter/engine#42010) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
…ne (#42244) ## Description This PR updates the Windows text input plugin to avoid adding a new line on a multiline text field when action is not set to `TextInputAction.newline`. ## Related Issue Fixes flutter/flutter#125879 as Linux and macOS implementations are merged. Linux PR: #41895 macOS PR: #41977 ## Tests Adds 2 tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the macOS text input plugin to avoid adding a new line on a multiline text field when action is not set to
TextInputAction.newline.Related Issue
macOS implementation for flutter/flutter#125879.
(similar to the Linux implementation in #41895).
Tests
Adds 2 tests.