Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] starts running vulkan golden image tests with swiftshader #41958

Merged
merged 4 commits into from
May 12, 2023
Merged

[Impeller] starts running vulkan golden image tests with swiftshader #41958

merged 4 commits into from
May 12, 2023

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented May 11, 2023 •
edited
Loading

fixes flutter/flutter#126022

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the vulkan-swiftshader branch 2 times, most recently from 49daef8 to caccef8 Compare May 11, 2023 20:53
@gaaclarke gaaclarke force-pushed the vulkan-swiftshader branch from 57b3558 to 8211786 Compare May 11, 2023 22:42
gaaclarke
gaaclarke commented May 11, 2023
View reviewed changes
impeller/golden_tests/golden_playground_test_mac.cc
: pimpl_(new GoldenPlaygroundTest::GoldenPlaygroundTestImpl()) {}

void GoldenPlaygroundTest::TearDown() {
ASSERT_FALSE(dlopen("/usr/local/lib/libMoltenVK.dylib", RTLD_NOLOAD));
Copy link
Member Author

@gaaclarke gaaclarke May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to make sure we don't accidentally swap out the backend.

gaaclarke
gaaclarke commented May 11, 2023
View reviewed changes
testing/run_tests.py
'impeller_unittests',
executable_filter,
shuffle_flags,
['--gtest_filter=-*/Vulkan'] + shuffle_flags,
Copy link
Member Author

@gaaclarke gaaclarke May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the bot is building with vulkan enabled we need to turn these tests off. I tried to run them with swiftshader and it didn't work. I didn't look into it closely, opting to turn them off instead. It doesn't seem worthwhile to make this a flag.

@gaaclarke gaaclarke marked this pull request as ready for review May 11, 2023 23:03
@gaaclarke gaaclarke requested a review from bdero May 11, 2023 23:03
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 11, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #41958 at sha 8211786

bdero
bdero approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot merged commit 502e1eb into flutter:main May 12, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2023
@engine-flutter-autoroll
502e1eb59 [Impeller] starts running vulkan golden image tests with sw…
e5fcecc 
…iftshader (flutter/engine#41958)
zanderso pushed a commit to flutter/flutter that referenced this pull request May 12, 2023
@engine-flutter-autoroll
Roll Flutter Engine from c784d6d4137d to 502e1eb591d9 (14 revisions) (#…
d5bb1a8 
…126714)

flutter/engine@c784d6d...502e1eb

2023-05-12 [email protected] [Impeller] starts
running vulkan golden image tests with swiftshader
(flutter/engine#41958)
2023-05-12 [email protected] [web] Fix crash on old versions of Chrome
(Intl.Segmenter missing) (flutter/engine#41986)
2023-05-12 [email protected] Move clang tidy v2 build to prod.
(flutter/engine#41985)
2023-05-12 [email protected] Reland "Move linux_license to engine
v2."" (flutter/engine#41983)
2023-05-12 [email protected] Roll Dart SDK from
6cd6e54f280d to 858f83d6d993 (2 revisions) (flutter/engine#41980)
2023-05-12 [email protected] Roll Skia from 0b929ada9cc6 to
539fb10d7cfb (2 revisions) (flutter/engine#41979)
2023-05-12 [email protected] Roll Fuchsia Mac SDK from
MjcKzcsqMDkuRKopu... to rO5qs4MpN6WfJcu64... (flutter/engine#41975)
2023-05-12 [email protected] Roll Dart SDK from
4028c7d8b87c to 6cd6e54f280d (1 revision) (flutter/engine#41974)
2023-05-12 [email protected] Roll Fuchsia Linux SDK from
lf8VcONMWlne4oa3H... to HMLNsG7w9sTDpW2Ge... (flutter/engine#41973)
2023-05-12 [email protected] Roll Skia from 208a07f71701 to
0b929ada9cc6 (2 revisions) (flutter/engine#41971)
2023-05-12 [email protected] [Impeller] [Android] Refactor the Android
context/surface implementation to work more like Skia.
(flutter/engine#41059)
2023-05-12 [email protected] Roll Skia from ccec5093ca38 to
208a07f71701 (1 revision) (flutter/engine#41970)
2023-05-12 [email protected] [Impeller] Dont synthesize fake
index buffer if none was provided to VBB (flutter/engine#41969)
2023-05-12 [email protected] [Impeller] Make index buffer optional
(flutter/engine#41962)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from lf8VcONMWlne to HMLNsG7w9sTD
  fuchsia/sdk/core/mac-amd64 from MjcKzcsqMDku to rO5qs4MpN6Wf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Flutter Engine from c784d6d4137d to 502e1eb591d9 (14 revisions) (f…
07ea019 
…lutter#126714)

flutter/engine@c784d6d...502e1eb

2023-05-12 [email protected] [Impeller] starts
running vulkan golden image tests with swiftshader
(flutter/engine#41958)
2023-05-12 [email protected] [web] Fix crash on old versions of Chrome
(Intl.Segmenter missing) (flutter/engine#41986)
2023-05-12 [email protected] Move clang tidy v2 build to prod.
(flutter/engine#41985)
2023-05-12 [email protected] Reland "Move linux_license to engine
v2."" (flutter/engine#41983)
2023-05-12 [email protected] Roll Dart SDK from
6cd6e54f280d to 858f83d6d993 (2 revisions) (flutter/engine#41980)
2023-05-12 [email protected] Roll Skia from 0b929ada9cc6 to
539fb10d7cfb (2 revisions) (flutter/engine#41979)
2023-05-12 [email protected] Roll Fuchsia Mac SDK from
MjcKzcsqMDkuRKopu... to rO5qs4MpN6WfJcu64... (flutter/engine#41975)
2023-05-12 [email protected] Roll Dart SDK from
4028c7d8b87c to 6cd6e54f280d (1 revision) (flutter/engine#41974)
2023-05-12 [email protected] Roll Fuchsia Linux SDK from
lf8VcONMWlne4oa3H... to HMLNsG7w9sTDpW2Ge... (flutter/engine#41973)
2023-05-12 [email protected] Roll Skia from 208a07f71701 to
0b929ada9cc6 (2 revisions) (flutter/engine#41971)
2023-05-12 [email protected] [Impeller] [Android] Refactor the Android
context/surface implementation to work more like Skia.
(flutter/engine#41059)
2023-05-12 [email protected] Roll Skia from ccec5093ca38 to
208a07f71701 (1 revision) (flutter/engine#41970)
2023-05-12 [email protected] [Impeller] Dont synthesize fake
index buffer if none was provided to VBB (flutter/engine#41969)
2023-05-12 [email protected] [Impeller] Make index buffer optional
(flutter/engine#41962)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from lf8VcONMWlne to HMLNsG7w9sTD
  fuchsia/sdk/core/mac-amd64 from MjcKzcsqMDku to rO5qs4MpN6Wf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bdero bdero bdero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App will affect goldens

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] Wire up a SwiftShader backend for Impeller unit-tests.

2 participants

@gaaclarke @bdero