This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] check if path is Rect/RRect/Oval #41744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
approved these changes
May 4, 2023
| } else if (path.isRRect(&rrect) && rrect.isSimple()) { | ||
| canvas_.DrawRRect(skia_conversions::ToRect(rrect.rect()), | ||
| rrect.getSimpleRadii().fX, paint_); | ||
| } else { |
Member
There was a problem hiding this comment.
DrawCircle would also push us into the rrect fast path for blurs if the color source is solid and there's a mask blur.
dnfield
reviewed
May 4, 2023
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Would it make sense to inject the Canvas so that we can test this? Otherwise LGTM
jonahwilliams
changed the title
jonahwilliams
added
the
autosubmit
Contributor
Author
|
Its really only a performance optimization. I expect that we'll see something in our benchmarks change with this... |
jonahwilliams
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 5, 2023
…126115) flutter/engine@4d50706...269ce2d 2023-05-05 [email protected] Roll Fuchsia Mac SDK from SD8Q_B7eWZqLgqo0f... to de2Eqw0IsOzTq15m3... (flutter/engine#41755) 2023-05-04 [email protected] Roll Skia from 00693e987828 to 6577130e14b6 (1 revision) (flutter/engine#41752) 2023-05-04 [email protected] Revert "Skwasm Font Loading" (flutter/engine#41750) 2023-05-04 [email protected] Roll Dart SDK from 95e133dbd3a6 to afeed9f8701e (1 revision) (flutter/engine#41749) 2023-05-04 [email protected] Fix flaky FlutterChannelsTests, stop mocking `NSObject` (flutter/engine#41747) 2023-05-04 [email protected] Roll Skia from a4828415b4af to 00693e987828 (6 revisions) (flutter/engine#41746) 2023-05-04 [email protected] Migrate linux unopt to engine_v2. (flutter/engine#41658) 2023-05-04 [email protected] [Impeller] check if path is Rect/RRect/Oval (flutter/engine#41744) 2023-05-04 [email protected] Add temporary staging GN arg for Skia roll (flutter/engine#41743) 2023-05-04 [email protected] Roll buildroot to 05ec9f7124191c7ba354521f3ffd34b09af872e7 (flutter/engine#41736) 2023-05-04 [email protected] Roll Dart SDK from 7b56aac98a5a to 95e133dbd3a6 (1 revision) (flutter/engine#41741) 2023-05-04 [email protected] Disable flaky tests on arm64 (flutter/engine#41740) 2023-05-04 [email protected] Roll Skia from 6950f56ad2ec to a4828415b4af (2 revisions) (flutter/engine#41737) 2023-05-04 [email protected] Roll Fuchsia Linux SDK from LIacrdFhuTuHnYh0B... to m0-fwGyFnoDVAvxgk... (flutter/engine#41738) 2023-05-04 [email protected] Skwasm Font Loading (flutter/engine#41246) 2023-05-04 [email protected] Migrate linux_host_engine to engine v2. (flutter/engine#41715) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from LIacrdFhuTuH to m0-fwGyFnoDV fuchsia/sdk/core/mac-amd64 from SD8Q_B7eWZqL to de2Eqw0IsOzT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids tessellation if the application draws a Rect or RREct with Path.addRect or Path.addRREct.