This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Make Metal layers readable #41085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 11, 2023
Member
|
If this assumption is changing now, we should make the Vulkan backend do similar things as well. See |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2023
bdero
added a commit
that referenced
this pull request
Apr 12, 2023
Removes the "final blit" for Metal because #41085 allows us to read from the onscreen texture. We can't do this trick when running the Vulkan backend right now because it doesn't have `SupportsReadFromResolve` yet, which means we need to toggle between two textures.
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
Resolves flutter/flutter#124612. Doing this would also allow us to remove the final blit on iOS when advanced blends/backdrop filters are present (all of the facilities would remain in place for GLES + Vulkan though).
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
Removes the "final blit" for Metal because flutter#41085 allows us to read from the onscreen texture. We can't do this trick when running the Vulkan backend right now because it doesn't have `SupportsReadFromResolve` yet, which means we need to toggle between two textures.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
May 25, 2023
Resolves flutter/flutter#124612. Doing this would also allow us to remove the final blit on iOS when advanced blends/backdrop filters are present (all of the facilities would remain in place for GLES + Vulkan though). (cherry picked from commit ef089a6)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#124612.
Doing this would also allow us to remove the final blit on iOS when advanced blends/backdrop filters are present (all of the facilities would remain in place for GLES + Vulkan though).