[mac] Build mac framework with app extension flag #41011
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| framework_search_path = rebase_path("$root_out_dir") | ||
| visibility = [ ":*" ] | ||
| cflags_objc = [ "-F$framework_search_path" ] | ||
|
|
||
| ldflags = [ | ||
| "-F$framework_search_path", | ||
| "-fapplication-extension", | ||
| "-Xlinker", | ||
| "-fatal_warnings", | ||
| ] | ||
| frameworks = [ "FlutterMacOS.framework" ] | ||
|
|
||
| sources = [ "framework/Source/FlutterUmbrellaImport.m" ] | ||
|
|
||
| deps = [ ":_generate_symlinks" ] |
There was a problem hiding this comment.
This is the test. @Hixie
This build target will fail if the FlutterMacOS framework is not application extension safe.
There was a problem hiding this comment.
If you haven't yet you'll need to ping him in Discord in the #hackers channel.
You could also rename tFlutterUmbrellaImport to something that would indicate it's a test https://github.com/flutter/cocoon/blob/412b236f4b16175e9459cdcff430147da4f6ff37/app_dart/lib/src/request_handlers/github/webhook_subscription.dart#L35
cyanglaz
force-pushed
the
app_extension_macos
branch
from
cdbff59 to
02fb42e
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
fix license golde
cyanglaz
force-pushed
the
app_extension_macos
branch
from
02fb42e to
5644791
Compare
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM, glad the macOS side Just Worked.
ci/licenses_golden/licenses_flutter
Outdated
| ORIGIN: ../../../flutter/shell/platform/darwin/ios/framework/Source/FlutterUIPressProxy.h + ../../../flutter/LICENSE | ||
| ORIGIN: ../../../flutter/shell/platform/darwin/ios/framework/Source/FlutterUIPressProxy.mm + ../../../flutter/LICENSE | ||
| ORIGIN: ../../../flutter/shell/platform/darwin/ios/framework/Source/FlutterUmbrellaImport.m + ../../../flutter/LICENSE | ||
| ORIGIN: ../../../flutter/shell/platform/darwin/ios/framework/Source/tFlutterUmbrellaImportTests.m + ../../../flutter/LICENSE |
There was a problem hiding this comment.
Stray t in the front.
| ORIGIN: ../../../flutter/shell/platform/darwin/ios/framework/Source/tFlutterUmbrellaImportTests.m + ../../../flutter/LICENSE | |
| ORIGIN: ../../../flutter/shell/platform/darwin/ios/framework/Source/FlutterUmbrellaImportTests.m + ../../../flutter/LICENSE |
|
Golden file change is probably the same as: flutter/flutter#124295 Will ignore the message in this PR. |
cyanglaz
added
the
autosubmit
[mac] Build mac framework with app extension flag
2 participants
Build macos framework with fapplication-extension flag.
Added a test to ensure a extension target can link to the framework (with -fapplication-extension)
To fully support extensions on macos, we still need to modify FlutterDartProject for the extension to find the flutter frameworks bundle. Since #37421 seems to be landing soon, we can wait for it lands.
part of flutter/flutter#124290
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.