This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[a11y] Use DartConverter for embedder a11y tests #40993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
embedder-a11y-unittest-cleanup
branch
2 times, most recently
from
c47ba05 to
2428b4d
Compare
No semantic change. This just simplifies converting Dart arguments to C++ types, making it more consistent with the rest of the codebase.
cbracken
force-pushed
the
embedder-a11y-unittest-cleanup
branch
from
2428b4d to
4972e08
Compare
loic-sharma
reviewed
Apr 7, 2023
| ASSERT_FALSE(Dart_IsError(handle)); | ||
| Dart_Handle exception = nullptr; | ||
| bool enabled = | ||
| ::tonic::DartConverter<bool>::FromArguments(args, 0, exception); |
There was a problem hiding this comment.
Should we check exception is still null?
loic-sharma
approved these changes
Apr 7, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 7, 2023
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
No semantic change. This just simplifies converting Dart arguments to C++ types, making it more consistent with the rest of the codebase. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No semantic change. This just simplifies converting Dart arguments to C++ types, making it more consistent with the rest of the codebase.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.