Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@htoor3
Copy link
Contributor

@htoor3 htoor3 commented Apr 6, 2023

Password input autofill + suggest password functionality is broken for password inputs inside of a shadowDOM on chrome. This experiment is testing to see if we can lift text editing nodes outside of the shadowDOM while maintaining functionality.

  1. Create a new host node outside of the shadowDOM for text-editing + accessibility
  2. Attach all text editing nodes, accessibility placeholders, and semantics tree into that node
  3. Ensure text editing + accessibility global styles are applied to new host node

Tree goes from:

                flt-glass-pane
                      |
                 #shadow-root
                      |
                 text nodes

to:

                            flutter-view
           -----------------------------------------------
           /                        |                  \
  flt-glass-pane             text-editing-host   semantics-host
          /  \                      |                  |
#shadow-root platform views     text nodes       semantics nodes

Will need to reland this after flutter/flutter#124299 merges.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 6, 2023
@htoor3
Copy link
Contributor Author

htoor3 commented Apr 11, 2023

flutter/flutter#124299 is merged to fix the previously blocking framework test. This should be good to merge now, but will monitor in case of any issues.

@htoor3 htoor3 added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit 2fbc99f into flutter:main Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
…#40968)

[web] - Move text editing nodes outside of shadowDOM, reland
@philyang07
Copy link

Hey, I was just wondering when this change will be accessible from stable?

@htoor3
Copy link
Contributor Author

htoor3 commented May 2, 2023

Hey @philyang07, the next stable release is tentatively scheduled for August. You have a couple of options if you need it sooner (and can't use master):

  1. You can try to use beta, which is branched off of master and is relatively more stable (only high priority cherrypicks are accepted). Release schedule says a new beta gets cut on the first Wednesday of the month, so you can see if the changes land tomorrow 5/3.
  2. You can cherrypick these changes and build your own version of engine until stable is released.

I'd recommend option 1 as there's less setup needed on your end. Hope this helps!

@rmahmadkhan
Copy link

hi @htoor3, is there any other workaround for using autofill password on web if we don't want to go with these options?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants