This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[web] - Move text editing nodes outside of shadowDOM, reland #40968
Merged
auto-submit
merged 2 commits into
flutter:main
from
htoor3:pass-autofill-fix-reland-again
Apr 11, 2023
Merged
[web] - Move text editing nodes outside of shadowDOM, reland #40968
auto-submit
merged 2 commits into
flutter:main
from
htoor3:pass-autofill-fix-reland-again
Apr 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Apr 10, 2023
Contributor
Author
|
flutter/flutter#124299 is merged to fix the previously blocking framework test. This should be good to merge now, but will monitor in case of any issues. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2023
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
…#40968) [web] - Move text editing nodes outside of shadowDOM, reland
|
Hey, I was just wondering when this change will be accessible from stable? |
Contributor
Author
|
Hey @philyang07, the next stable release is tentatively scheduled for August. You have a couple of options if you need it sooner (and can't use
I'd recommend option 1 as there's less setup needed on your end. Hope this helps! |
|
hi @htoor3, is there any other workaround for using autofill password on web if we don't want to go with these options? |
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
platform-web
Code specifically for the web engine
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Password input autofill + suggest password functionality is broken for password inputs inside of a shadowDOM on chrome. This experiment is testing to see if we can lift text editing nodes outside of the shadowDOM while maintaining functionality.
Tree goes from:
to:
Will need to reland this after flutter/flutter#124299 merges.