Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Migrate mac_unopt to engine_v2. #40860

Merged
merged 12 commits into from
Apr 5, 2023
Merged

Migrate mac_unopt to engine_v2. #40860

merged 12 commits into from
Apr 5, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Apr 2, 2023

Initial migration of mac_unopt to engine_v2 builds.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Migrate mac_unopt to engine_v2.
07a2277 
Initial migration of mac_unopt to engine_v2 builds.
@godofredoc godofredoc marked this pull request as draft April 2, 2023 00:43
@godofredoc godofredoc marked this pull request as ready for review April 5, 2023 14:44
@godofredoc godofredoc requested a review from zanderso April 5, 2023 14:44
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit auto-submit bot merged commit 3f6a278 into flutter:main Apr 5, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
3f6a2785b Migrate mac_unopt to engine_v2. (flutter/engine#40860)
2f5b360
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
3f6a2785b Migrate mac_unopt to engine_v2. (flutter/engine#40860)
e9337d8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
3f6a2785b Migrate mac_unopt to engine_v2. (flutter/engine#40860)
149bfb8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
3f6a2785b Migrate mac_unopt to engine_v2. (flutter/engine#40860)
2de9cfe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
3f6a2785b Migrate mac_unopt to engine_v2. (flutter/engine#40860)
156b64f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
3f6a2785b Migrate mac_unopt to engine_v2. (flutter/engine#40860)
76c4b38
@godofredoc godofredoc deleted the migrate_unopt branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @zanderso