Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Sync Mac Host Engine with its engine v2 counterpart. #40856

Merged
merged 4 commits into from
Apr 3, 2023
Merged

Sync Mac Host Engine with its engine v2 counterpart. #40856

merged 4 commits into from
Apr 3, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Apr 1, 2023

This is to ensure the engine v2 build include everything from the legacy builder in addition to the new tests added to engine_v2.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc marked this pull request as draft April 1, 2023 23:33
@godofredoc
Sync Mac Host Engine with its engine v2 counterpart.
50d1e16 
This is to ensure the engine v2 build include everything from the legacy
builder in addition to the new tests added to engine_v2.
@godofredoc
Remove extra apostrophe.
3ecbad0
@godofredoc
Run unittest target to release config.
0dfda41
@godofredoc godofredoc marked this pull request as ready for review April 3, 2023 16:10
@godofredoc godofredoc requested a review from zanderso April 3, 2023 16:11
zanderso
zanderso reviewed Apr 3, 2023
View reviewed changes
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit auto-submit bot merged commit e5dcd12 into flutter:main Apr 3, 2023
@godofredoc godofredoc deleted the sync_host_engine branch April 3, 2023 18:24
zanderso added a commit that referenced this pull request Apr 3, 2023
@zanderso
Revert "Sync Mac Host Engine with its engine v2 counterpart. (#40856)"
6635607 
This reverts commit e5dcd12.
@zanderso zanderso mentioned this pull request Apr 3, 2023
Merged
zanderso added a commit that referenced this pull request Apr 3, 2023
@zanderso
Revert "Sync Mac Host Engine with its engine v2 counterpart." (#40892)
7a5cc1c 
Reverts #40856

Failure on
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20mac_host_engine/2864/overview
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2023
@engine-flutter-autoroll
e5dcd12db Sync Mac Host Engine with its engine v2 counterpart. (flutt…
2cff60c 
…er/engine#40856)
@godofredoc godofredoc mentioned this pull request Apr 4, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @zanderso