Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove ios-release-nobitcode from engine v2 builders. #40830

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Remove ios-release-nobitcode from engine v2 builders. #40830

merged 2 commits into from
Mar 31, 2023

Conversation

godofredoc
Copy link
Contributor

These artifacts were removed from the legacy builders in https://flutter-review.googlesource.com/c/recipes/+/34780

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc requested review from zanderso and jmagman March 31, 2023 21:37
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
@auto-submit auto-submit bot merged commit 4a99cc0 into flutter:main Mar 31, 2023
@godofredoc godofredoc deleted the remove-nobitcode-artifacts branch March 31, 2023 23:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
2051833 
…ter/engine#40830)
@jmagman
Copy link
Member

jmagman commented Mar 31, 2023

LGTM

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
4a29da9 
…ter/engine#40830)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
f8bd295 
…ter/engine#40830)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
389729d 
…ter/engine#40830)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
bb4a1c9 
…ter/engine#40830)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
408b6ac 
…ter/engine#40830)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
f3aef75 
…ter/engine#40830)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
0923244 
…ter/engine#40830)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4a99cc0b1 Remove ios-release-nobitcode from engine v2 builders. (flut…
b080d91 
…ter/engine#40830)
zanderso pushed a commit to flutter/flutter that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from b2855e074deb to a48eedbda125 (15 revi…
7725f59 
…sions) (#123924)

Manual roll requested by [email protected]

flutter/engine@b2855e0...a48eedb

2023-04-01 [email protected] Revert "[web] Move text
editing nodes outside of shadowDOM" (flutter/engine#40847)
2023-04-01 [email protected] Roll Skia from 4d1e9cabf0c8 to
9973ef180f1f (2 revisions) (flutter/engine#40843)
2023-04-01 [email protected] Roll Dart SDK from
6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842)
2023-04-01 [email protected] [Impeller] take advantage of native
decal sampling, blend cleanups (flutter/engine#40839)
2023-04-01 [email protected] Revert "[web] use callConstructor for
FinalizationRegistry due to bug… (flutter/engine#40841)
2023-04-01 [email protected] Revert "Add ui_web to
embedder.yaml so that the analyzer knows about it."
(flutter/engine#40840)
2023-04-01 [email protected] [Impeller] Migrate gaussian blur to
half precision. (flutter/engine#40800)
2023-03-31 [email protected] Roll Skia from 33f80c07a09c to
4d1e9cabf0c8 (3 revisions) (flutter/engine#40836)
2023-03-31 [email protected] [web] Move text
editing nodes outside of shadowDOM (flutter/engine#39688)
2023-03-31 [email protected] [web] Fix canvasKitVariant test
(flutter/engine#40833)
2023-03-31 [email protected] [web] use callConstructor for
FinalizationRegistry due to bug in dart2js (flutter/engine#40798)
2023-03-31 [email protected] Roll Fuchsia Mac SDK from
kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831)
2023-03-31 [email protected] Remove ios-release-nobitcode from
engine v2 builders. (flutter/engine#40830)
2023-03-31 [email protected] Add ui_web to embedder.yaml so that
the analyzer knows about it. (flutter/engine#40827)
2023-03-31 [email protected] Roll Skia from 2b86c6d364d0 to
33f80c07a09c (1 revision) (flutter/engine#40826)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@engine-flutter-autoroll @exaby73
Manual roll Flutter Engine from b2855e074deb to a48eedbda125 (15 revi…
294f161 
…sions) (flutter#123924)

Manual roll requested by [email protected]

flutter/engine@b2855e0...a48eedb

2023-04-01 [email protected] Revert "[web] Move text
editing nodes outside of shadowDOM" (flutter/engine#40847)
2023-04-01 [email protected] Roll Skia from 4d1e9cabf0c8 to
9973ef180f1f (2 revisions) (flutter/engine#40843)
2023-04-01 [email protected] Roll Dart SDK from
6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842)
2023-04-01 [email protected] [Impeller] take advantage of native
decal sampling, blend cleanups (flutter/engine#40839)
2023-04-01 [email protected] Revert "[web] use callConstructor for
FinalizationRegistry due to bug… (flutter/engine#40841)
2023-04-01 [email protected] Revert "Add ui_web to
embedder.yaml so that the analyzer knows about it."
(flutter/engine#40840)
2023-04-01 [email protected] [Impeller] Migrate gaussian blur to
half precision. (flutter/engine#40800)
2023-03-31 [email protected] Roll Skia from 33f80c07a09c to
4d1e9cabf0c8 (3 revisions) (flutter/engine#40836)
2023-03-31 [email protected] [web] Move text
editing nodes outside of shadowDOM (flutter/engine#39688)
2023-03-31 [email protected] [web] Fix canvasKitVariant test
(flutter/engine#40833)
2023-03-31 [email protected] [web] use callConstructor for
FinalizationRegistry due to bug in dart2js (flutter/engine#40798)
2023-03-31 [email protected] Roll Fuchsia Mac SDK from
kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831)
2023-03-31 [email protected] Remove ios-release-nobitcode from
engine v2 builders. (flutter/engine#40830)
2023-03-31 [email protected] Add ui_web to embedder.yaml so that
the analyzer knows about it. (flutter/engine#40827)
2023-03-31 [email protected] Roll Skia from 2b86c6d364d0 to
33f80c07a09c (1 revision) (flutter/engine#40826)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman Awaiting requested review from jmagman

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@godofredoc @jmagman @zanderso