This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Sequester all Skia<->DL interactions into the skia sub-module" #40435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e408e09.
chinmaygarde
approved these changes
Mar 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 20, 2023
…sub-module" (flutter/engine#40435) (#122991) Roll Flutter Engine from 19a5f61ff72d to 25514eca7dc4 (1 revision)
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 20, 2023
…the skia sub-module" (flutter/engine#40435) (#122991) Commit: 21f60bbe0d77d1a0dd9a44722479009ae697c6fb
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 20, 2023
* 0dd46a3 Roll Flutter Engine from f339103089c6 to dc6e389aea9a (4 revisions) (flutter/flutter#122980) * 1cd5593 19a5f61ff Roll Fuchsia Mac SDK from M0fRocbi0LTExrYQ3... to 7Qlskx4DM6DhfDQ8x... (flutter/engine#40442) (flutter/flutter#122988) * 21f60bb 25514eca7 Reland "Sequester all Skia<->DL interactions into the skia sub-module" (flutter/engine#40435) (flutter/flutter#122991) * e4facef Roll Flutter Engine from 25514eca7dc4 to a79250732dfe (8 revisions) (flutter/flutter#123008) * 23f5582 68334e959 Roll Skia from 5b2cbd717b55 to 942757383cc2 (1 revision) (flutter/engine#40450) (flutter/flutter#123012)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
* 0dd46a3 Roll Flutter Engine from f339103089c6 to dc6e389aea9a (4 revisions) (flutter/flutter#122980) * 1cd5593 19a5f61ff Roll Fuchsia Mac SDK from M0fRocbi0LTExrYQ3... to 7Qlskx4DM6DhfDQ8x... (flutter/engine#40442) (flutter/flutter#122988) * 21f60bb 25514eca7 Reland "Sequester all Skia<->DL interactions into the skia sub-module" (flutter/engine#40435) (flutter/flutter#122991) * e4facef Roll Flutter Engine from 25514eca7dc4 to a79250732dfe (8 revisions) (flutter/flutter#123008) * 23f5582 68334e959 Roll Skia from 5b2cbd717b55 to 942757383cc2 (1 revision) (flutter/engine#40450) (flutter/flutter#123012)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40357
A large number of golden failures downstream resulted in splitting out the change in drawTextBlob opacity inheritance from the rest of the changes to separate the potential causes. This PR relands the "sequester" set of changes while the text opacity changes have already been re-landed in #40396