Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion display_list/display_list_builder.h
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ class DisplayListBuilder final : public virtual DlCanvas,

bool has_layer() const { return has_layer_; }
bool cannot_inherit_opacity() const { return cannot_inherit_opacity_; }
bool has_compatible_op() const { return cannot_inherit_opacity_; }
bool has_compatible_op() const { return has_compatible_op_; }

bool is_group_opacity_compatible() const {
return !cannot_inherit_opacity_;
Expand Down
12 changes: 12 additions & 0 deletions display_list/display_list_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2403,5 +2403,17 @@ TEST(DisplayList, RTreeRenderCulling) {
}
}

TEST(DisplayListTest, DrawSaveDrawCannotInheritOpacity) {
DisplayListBuilder builder;
builder.DrawCircle({10, 10}, 5, DlPaint());
builder.Save();
builder.ClipRect({0, 0, 20, 20}, DlCanvas::ClipOp::kIntersect, false);
builder.DrawRect({5, 5, 15, 15}, DlPaint());
builder.Restore();
auto display_list = builder.Build();

ASSERT_FALSE(display_list->can_apply_group_opacity());
}

} // namespace testing
} // namespace flutter