Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

Handling of keyboard focus for Flutter text fields appears to have regressed with #39473, which removed the call to gtk_widget_set_can_focus

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm. Thanks for spotting. I'm guessing we didn't have a test for this or it would already have been failing.

It looks like we should be able to test this with gtk_widget_get_can_focus.

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot of focus related calls that seemed redundant in the code before the simplification, I guess I took out one too many. Confirmed it was broken and this fixes it.

@robert-ancell
Copy link
Contributor

Adding a test for gtk_widget_get_can_focus would catch a regression in this one particular line, but what we really want is a test that generates a key event and confirms it gets all the way to Flutter. There's a lot of focus / keyboard handling code that could regress.

Hopefully this PR can get a test exemption, but the test proposed by @cbracken should be sufficient if not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants