This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Sequester all Skia<->DL interactions into the skia sub-module" #40114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Filter/Metal' (flutter#40105)" This reverts commit 0eefca4.
…flutter#40083)" This reverts commit b3e314e.
jason-simmons
approved these changes
Mar 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2023
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Mar 9, 2023
…b-module" (flutter#40114)" (flutter#40161) Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module""
CaseyHillers
pushed a commit
that referenced
this pull request
Mar 9, 2023
…ia sub-module" (#40114)" (#40161) (#40187) Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module"" Co-authored-by: Jim Graham <[email protected]>
Contributor
Author
|
Also, note performance regression related to gradients (likely due to data copying in the ToSk(gradient) code): |
Contributor
Author
|
Also (probably the same measurement reported under 2 different categories): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version of this PR (#40083) ran afoul of some customer tests due to confusion about the last parameter of drawImageRect. It used to use
SkCanvas::SrcRectConstraint, but was switched to a bool during 40083 in order to remove the minor dependency on Skia types. Unfortunately, since theSKCanvasenums are base enums, they willfully implicitly cast back and forth with numeric types like "bool", so some call sites that were using the Sk values were not detected during testing. To make matters worse,bool(0) == falserepresents "don't enforce the src rect edges" whereas `SrcRectConstraint(0) == kStrict" which means "do enforce the edges".The solution is to make the
DlCanvasandDlOpReceiverversions of[dD]rawImageRecttake a newDlCanvas::SrcRectConstraintwhich is a type-safeenum class. Lots of lines changed and call sites get more verbose, but the type safety is worth it in the long run.