This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Uniquely label offscreen resources #39987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
force-pushed
the
bdero/label-offscreen
branch
from
1884f6b to
0db3ce3
Compare
godofredoc
added a commit
that referenced
this pull request
Mar 1, 2023
This reverts commit 8c9a358.
|
Reverting because the ios builds got broken: |
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Mar 1, 2023
…flutter#39993)" This reverts commit f249919.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2023
chinmaygarde
pushed a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Mar 3, 2023
[Impeller] Uniquely label offscreen resources
chinmaygarde
pushed a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Mar 3, 2023
flutter#39993) Revert "[Impeller] Uniquely label offscreen resources"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force a label to be provided when using the offscreen pass utility. Right now, offscreen resources created by contents/filters all get the same names. This has always been a minor headache, but a couple of days ago this caused me quite a bit of friction when xcode decided to start incorrectly showing black textures for all of the pass previews.