This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fire TextInputClient.updateEditingState on text changes (iOS) #3995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with Android, when the engine receives a TextInput.setEditingState message from the framework, and the text has changed, we now send a TextInputClient.updateEditingState message back to the framework with the updated state from the engine. The framework currently relies on this behaviour to trigger onChanged events in certain scenarios (e.g., on tapping Paste in the selection controls). Note: it may be more desirable for the framework to trigger the onChanged calls without relying on the return message from the engine, but this change ensures consistent behaviour across iOS and Android until we've evaluated the pros/cons of such an approach.
jason-simmons
approved these changes
Aug 21, 2017
Member
Author
|
Fixes flutter/flutter#11671 |
fredriks
added a commit
to fredriks/engine
that referenced
this pull request
Jan 6, 2018
…flutter#3995)" This reverts commit 600567e.
This was referenced Sep 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with Android, when the engine receives a
TextInput.setEditingState message from the framework, and the text has
changed, we now send a TextInputClient.updateEditingState message back
to the framework with the updated state from the engine. The framework
currently relies on this behaviour to trigger onChanged events in
certain scenarios (e.g., on tapping Paste in the selection controls).
Note: it may be more desirable for the framework to trigger the
onChanged calls without relying on the return message from the engine,
but this change ensures consistent behaviour across iOS and Android
until we've evaluated the pros/cons of such an approach.