This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[impeller] support generating mip-maps on Vulkan #39689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
force-pushed
the
generate-mip-maps
branch
from
a9d95f2 to
59bc057
Compare
Contributor
Author
|
|
chinmaygarde
approved these changes
Feb 17, 2023
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM but I think you forgot to back out the part where you opted into Vulkan on Android.
|
|
||
| image_create_info.tiling = vk::ImageTiling::eOptimal; | ||
| image_create_info.initialLayout = vk::ImageLayout::eUndefined; | ||
| image_create_info.usage = vk::ImageUsageFlagBits::eSampled | |
Member
There was a problem hiding this comment.
This makes me think we should perhaps have a recommended usage as on optional on the texture descriptor. For later though.
| if (enable_impeller_) { | ||
| // TODO(kaushikiska@): Enable this after wiring a preference for Vulkan backend. | ||
| #if false | ||
| #if true |
Member
There was a problem hiding this comment.
Did you mean to leave this in?
iskakaushik
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
This was referenced Feb 17, 2023
Closed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 17, 2023
…121004) * 6a2a46a28 Roll Dart SDK from 3ec7f1f92216 to 7642080abaf7 (2 revisions) (flutter/engine#39702) * f6bb7ae5f Roll Skia from d0df677ffd5e to ba60fed7f075 (6 revisions) (flutter/engine#39703) * 27696d2b7 Cached DisplayList opacity inheritance fix (flutter/engine#39690) * 1ae94738d Roll Dart SDK from 7642080abaf7 to 42829b6f80b1 (1 revision) (flutter/engine#39707) * 676201790 Roll Fuchsia Linux SDK from yT4JLKTCWWwbRwB0l... to tMm2Lzb-LE20Rxwm9... (flutter/engine#39709) * 26f1f251f Roll Skia from ba60fed7f075 to 5637cd56be32 (3 revisions) (flutter/engine#39710) * 4b0b8f053 Roll Dart SDK from 42829b6f80b1 to c7ec16304216 (1 revision) (flutter/engine#39711) * 1f7aad3a4 Roll Fuchsia Mac SDK from haDvcC5VzWVdQs9Rs... to _wymybZYKzX_3iFd6... (flutter/engine#39715) * 067369d22 Migrate skia png codec call to public interface (flutter/engine#39714) * 7e190a49c Roll Dart SDK from c7ec16304216 to 8a7dc36cadf6 (1 revision) (flutter/engine#39716) * 83a896250 Roll Skia from 5637cd56be32 to 02890036028e (2 revisions) (flutter/engine#39717) * 6d9387433 [linux] Eliminate mirrors support (flutter/engine#39701) * adc0ebd97 Adds a Linux Fuchsia FEMU config that enables CSO (flutter/engine#39718) * 0378b3406 [impeller] support generating mip-maps on Vulkan (flutter/engine#39689) * 5212ac439 [Impeller] Device default attachment pixel formats (flutter/engine#39655) * bd37a3992 Rollback Dart SDK to unblock the roller (flutter/engine#39722)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: flutter/flutter#120134