Replace alwaysThrows annotation with Never return type #39272
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -224,8 +224,7 @@ class ProcessManager { | |||
| return (await eval()).stderr; | |||
| } | |||
|
|
|||
| @alwaysThrows | |||
| void _throwProcessException({required String description, int? exitCode}) { | |||
| Never _throwProcessException({required String description, int? exitCode}) { | |||
There was a problem hiding this comment.
You may be able to remove the package:meta import too? 🤔
There was a problem hiding this comment.
No they use @immutable
|
#39269 got here first. |
Fixes flutter/flutter#119582
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.