Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

miguelfrde
Copy link
Member

This reverts commit 225ae87.

The related CL https://fuchsia-review.git.corp.google.com/c/fuchsia/+/792471 is being reverted as well: https://fuchsia-review.git.corp.google.com/c/fuchsia/+/794843

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot changed the base branch from master to main January 31, 2023 00:02
@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@tarobins tarobins merged commit 9448f29 into flutter:main Jan 31, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 31, 2023
…119592)

* 999e5e5fc Rebase all (flutter/engine#38855)

* 9cc2a8e8f Update bytes str code (flutter/engine#39275)

* 9448f2966 Revert "[fuchsia] Diagnostics directory rights are R* (#39203)" (flutter/engine#39271)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants