Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 27, 2023

TODO

Fixes: ubuntu-flutter-community/software#868

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 27, 2023

I thought so but I had to try anyway :)

�[0;33mNote: Google Test filter = FlViewTest.SizeAllocate
�[m�[0;32m[==========] �[mRunning 1 test from 1 test suite.
�[0;32m[----------] �[mGlobal test environment set-up.
�[0;32m[----------] �[m1 test from FlViewTest
Unable to init server: Could not connect: Connection refused

(flutter_linux_unittests:8415): Gtk-WARNING **: 09:55:03.940: cannot open display:
[FATAL:flutter/fml/thread_local.cc(32)] Check failed: false. pthread_setspecific failed (22): Invalid argument
[ERROR:flutter/fml/backtrace.cc(108)] Caught signal SIGABRT during program execution.

} else {
// newly added child
gtk_widget_set_parent(pending_view_child->widget, GTK_WIDGET(view));
size_allocate_child(view, pending_view_child, &allocation);
Copy link
Contributor

@robert-ancell robert-ancell Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gtk_widget_size_allocate should only normally be called inside GtkWidget::size-allocate. If the size needs recalculating then gtk_widget_queue_resize should be here? Though I'd expect the gtk_widget_set_parent would trigger that. Perhaps the queue_resize is missing somewhere else?

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 8, 2023

@jpnurmi jpnurmi closed this Feb 8, 2023
@jpnurmi jpnurmi deleted the fl-gl-area-size-allocate branch July 1, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Application shows a grey box when first opened, only resolved on relaunch or resize

2 participants