Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

nanokatze
Copy link
Contributor

@nanokatze nanokatze commented Jan 24, 2023

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API needs tests labels Jan 24, 2023
@nanokatze nanokatze changed the title [embedder] Be backwards compatible when getting vkGetInstanceProcAddr Draft: [embedder] Be backwards compatible when getting vkGetInstanceProcAddr Jan 24, 2023
@nanokatze nanokatze marked this pull request as draft January 24, 2023 16:19
@Hixie
Copy link
Contributor

Hixie commented Apr 18, 2023

@nanokatze Did you want to land this?

@nanokatze
Copy link
Contributor Author

nanokatze commented Apr 19, 2023

I don't have any preference for either landing this or not. I opened this MR to address a concern brought up by @chinmaygarde in #39051 (comment). My personal opinion on this is that if change introduced by #39051 wasn't actually breaking anyone out there in practice, this PR should not be merged, as I don't see any point in adding compat cruft for bugs that nobody actually came to depend on.

@nanokatze nanokatze marked this pull request as ready for review April 19, 2023 12:40
@nanokatze nanokatze changed the title Draft: [embedder] Be backwards compatible when getting vkGetInstanceProcAddr [embedder] Be backwards compatible when getting vkGetInstanceProcAddr Apr 19, 2023
@chinmaygarde
Copy link
Member

Closing as this isn't a breaking change. Its possible this is confusing for implementers and we should document it at the very least.

@nanokatze nanokatze deleted the vk_embedder2 branch April 27, 2023 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
embedder Related to the embedder API needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants