This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[ui] make vertices validation slightly cheaper #38041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
force-pushed
the
remove_any_check
branch
from
d67e494 to
f5a5931
Compare
|
@Hixie is going to fold this into a pending change he has. Closing! |
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Dec 2, 2022
…improvement. * Remove nonsensical (and I think unnecessary?) comment. * Document willChangeHint, isComplexHint * Fix grammer in Rect docs * Remove runtimeType.toString twice * Add detail to ImageShader constructor docs. * Document Vertices and drawVertices! * Update checks in Vertices constructors (and add tests). * Fix some typos. * Minor other doc improvements. * Fold in @jonahwilliams' performance improvement from flutter#38041
8 tasks
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Dec 2, 2022
…improvement. * Remove nonsensical (and I think unnecessary?) comment. * Document willChangeHint, isComplexHint * Fix grammer in Rect docs * Remove runtimeType.toString twice * Add detail to ImageShader constructor docs. * Document Vertices and drawVertices! * Update checks in Vertices constructors (and add tests). * Fix some typos. * Minor other doc improvements. * Fold in @jonahwilliams' performance improvement from flutter#38041
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Dec 2, 2022
…improvement. * Remove nonsensical (and I think unnecessary?) comment. * Document willChangeHint, isComplexHint * Fix grammer in Rect docs * Remove runtimeType.toString twice * Add detail to ImageShader constructor docs. * Document Vertices and drawVertices! * Update checks in Vertices constructors (and add tests). * Fix some typos. * Minor other doc improvements. * Fold in @jonahwilliams' performance improvement from flutter#38041
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 3, 2022
…improvement. (#38047) * Remove nonsensical (and I think unnecessary?) comment. * Document willChangeHint, isComplexHint * Fix grammer in Rect docs * Remove runtimeType.toString twice * Add detail to ImageShader constructor docs. * Document Vertices and drawVertices! * Update checks in Vertices constructors (and add tests). * Fix some typos. * Minor other doc improvements. * Fold in @jonahwilliams' performance improvement from #38041
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old godbolt compile: https://godbolt.org/z/cvdGP4vPb
New godbolt compile: https://godbolt.org/z/cGnxqWcYs
This appears to generate better code since we don't use a closure. Additional removes the
<0check which is unnecessary because the int is read from an unsigned int list.