This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add setInitialRoute on FlutterView. #3727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @abarth who is more familiar with this code |
Contributor
|
Also cc @jason-simmons who was in this code recently. |
abarth
reviewed
Jun 2, 2017
lib/ui/window/window.cc
Outdated
|
|
||
| void DefaultRouteName(Dart_NativeArguments args) { | ||
| std::string routeName = UIDartState::Current()->window()->client()->DefaultRouteName(); | ||
| Dart_SetReturnValue(args, Dart_NewStringFromCString(routeName.c_str())); |
Contributor
There was a problem hiding this comment.
You can just call: Dart_SetReturnValue(args, StdStringToDart(routeName));
abarth
reviewed
Jun 2, 2017
shell/common/engine.cc
Outdated
| if (!initial_route_.empty()) { | ||
| return initial_route_; | ||
| } | ||
| return std::string("/"); |
Contributor
There was a problem hiding this comment.
No need for the explicit call to std::string. The compiler will add it for you.
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.