This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Store Paint.color as an int. Only create a ui.Color when the color getter is called. #37092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
approved these changes
Oct 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 2, 2022
…hen the color getter is called. (flutter/engine#37092)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…lor getter is called. (flutter#37092) * Store color as the int value. Only create a color when getter is called * Refactor tests and painting * Change SurfacePaintData to have default opaque black color
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than coerce the type of the stored color in a Paint to be exactly ui.Color (which involves an expensive
runtimeTypecheck), store just the int value of the color and coerce it into aui.Coloronly when thePaint.colorgetter is called.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.