Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Macos re-enable TestSetMenu #37058

Merged
merged 1 commit into from
Oct 27, 2022
+6 −3
Merged

Macos re-enable TestSetMenu #37058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions shell/platform/darwin/macos/framework/Source/FlutterMenuPluginTest.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ - (bool)testSetMenu;
@implementation FlutterMenuPluginTestObjc

- (bool)testSetMenu {
// Workaround to deflake the test.
// See: https://github.com/flutter/flutter/issues/104748#issuecomment-1159336728
NSView* view = [[NSView alloc] initWithFrame:NSZeroRect];
view.wantsLayer = YES;

// Build a simulation of the default main menu.
NSMenu* mainMenu = [[NSMenu alloc] init];
NSMenuItem* appNameMenu = [[NSMenuItem alloc] initWithTitle:@"APP_NAME"
Expand Down Expand Up @@ -175,9 +180,7 @@ - (bool)testSetMenu {
@end

namespace flutter::testing {
// TODO(gspencergoog): Re-enabled when deflaked
// https://github.com/flutter/flutter/issues/106589
TEST(FlutterMenuPluginTest, DISABLED_TestSetMenu) {
TEST(FlutterMenuPluginTest, TestSetMenu) {
ASSERT_TRUE([[FlutterMenuPluginTestObjc alloc] testSetMenu]);
}
} // namespace flutter::testing