Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@rmacnak-google
Copy link
Contributor

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member

@rmacnak-google This is just a draft PR for experimentation right?

@chinmaygarde chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Oct 20, 2022
@rmacnak-google
Copy link
Contributor Author

Yeah, I'm still trying to figure out the right place to get the needed isolate scope.

@chinmaygarde
Copy link
Member

Ah. Once on the UI task runner, you ought to be able to get the isolate handle from the thread local Dart state and enter it.

@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@rmacnak-google
Copy link
Contributor Author

-> #37539

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests Work in progress (WIP) Not ready (yet) for review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants