This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add Dart AOT integration test #36460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
From PR review triage: Marking as WIP/Draft. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
|
Gold has detected about 7 new digest(s) on patchset 20. |
richkadel
reviewed
Oct 6, 2022
...rt_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc
Outdated
Show resolved
Hide resolved
lin-erik
changed the title
lin-erik
added
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 36460, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
Contributor
|
auto label is removed for flutter/engine, pr: 36460, due to Validations Fail. |
akbiggs
approved these changes
Oct 7, 2022
shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_echo_server/README.md
Outdated
Show resolved
Hide resolved
lin-erik
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few changes to the existing Dart JIT integration test and adds the new Dart AOT integration test.
dart_echo_serverdirectory that contains both versions of the Echo server needed by the JIT/AOT integration tests. The versions will match the runner required by their respective test.oot_dart_*_runner. This is just a copy of thedart_*_runnerbut with a custom name. This will avoid conflicting with the Dart runners used in the base Fuchsia image. Changes made to the Dart runner are now picked up as expected.