This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add Dart JIT runner integration test #36420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbiggs
approved these changes
Sep 26, 2022
| } | ||
| } else { | ||
| not_needed("*") | ||
| } else if (current_toolchain == fidl_toolchain) { |
Contributor
There was a problem hiding this comment.
thanks for the cleanup here!
...ner/tests/startup_integration_test/dart_jit_runner/meta/dart-jit-runner-integration-test.cml
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/tests/fidl/flutter.example.echo/BUILD.gn
Outdated
Show resolved
Hide resolved
...rt_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc
Outdated
Show resolved
Hide resolved
...rt_runner/tests/startup_integration_test/dart_jit_runner/dart-jit-runner-integration-test.cc
Outdated
Show resolved
Hide resolved
...sia/dart_runner/tests/startup_integration_test/dart_jit_runner/dart_jit_echo_server/BUILD.gn
Outdated
Show resolved
Hide resolved
lin-erik
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an integration test for Dart JIT runner, PR contains a few major parts:
Test passes with latest checkout of dart_runner.cc. To simulate a bad change made to Dart runner, added a
return;to this line, which caused the test to fail.