Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fix typos buider -> builder #35104

Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix typos buider -> builder #35104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions display_list/display_list_builder_benchmarks.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,16 @@ static void Complete(DisplayListBuilder& builder,

} // namespace

static void BM_DisplayListBuiderDefault(benchmark::State& state,
DisplayListBuilderBenchmarkType type) {
static void BM_DisplayListBuilderDefault(benchmark::State& state,
DisplayListBuilderBenchmarkType type) {
while (state.KeepRunning()) {
DisplayListBuilder builder;
InvokeAllRenderingOps(builder);
Complete(builder, type);
}
}

static void BM_DisplayListBuiderWithScaleAndTranslate(
static void BM_DisplayListBuilderWithScaleAndTranslate(
benchmark::State& state,
DisplayListBuilderBenchmarkType type) {
while (state.KeepRunning()) {
Expand All @@ -69,7 +69,7 @@ static void BM_DisplayListBuiderWithScaleAndTranslate(
}
}

static void BM_DisplayListBuiderWithPerspective(
static void BM_DisplayListBuilderWithPerspective(
benchmark::State& state,
DisplayListBuilderBenchmarkType type) {
while (state.KeepRunning()) {
Expand All @@ -81,7 +81,7 @@ static void BM_DisplayListBuiderWithPerspective(
}
}

static void BM_DisplayListBuiderWithClipRect(
static void BM_DisplayListBuilderWithClipRect(
benchmark::State& state,
DisplayListBuilderBenchmarkType type) {
SkRect clip_bounds = SkRect::MakeLTRB(6.5, 7.3, 90.2, 85.7);
Expand All @@ -93,7 +93,7 @@ static void BM_DisplayListBuiderWithClipRect(
}
}

static void BM_DisplayListBuiderWithSaveLayer(
static void BM_DisplayListBuilderWithSaveLayer(
benchmark::State& state,
DisplayListBuilderBenchmarkType type) {
while (state.KeepRunning()) {
Expand All @@ -110,7 +110,7 @@ static void BM_DisplayListBuiderWithSaveLayer(
}
}

static void BM_DisplayListBuiderWithSaveLayerAndImageFilter(
static void BM_DisplayListBuilderWithSaveLayerAndImageFilter(
benchmark::State& state,
DisplayListBuilderBenchmarkType type) {
DlPaint layer_paint;
Expand All @@ -130,104 +130,104 @@ static void BM_DisplayListBuiderWithSaveLayerAndImageFilter(
}
}

BENCHMARK_CAPTURE(BM_DisplayListBuiderDefault,
BENCHMARK_CAPTURE(BM_DisplayListBuilderDefault,
kDefault,
DisplayListBuilderBenchmarkType::kDefault)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderDefault,
BENCHMARK_CAPTURE(BM_DisplayListBuilderDefault,
kBounds,
DisplayListBuilderBenchmarkType::kBounds)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderDefault,
BENCHMARK_CAPTURE(BM_DisplayListBuilderDefault,
kRtree,
DisplayListBuilderBenchmarkType::kRtree)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderDefault,
BENCHMARK_CAPTURE(BM_DisplayListBuilderDefault,
kBoundsAndRtree,
DisplayListBuilderBenchmarkType::kBoundsAndRtree)
->Unit(benchmark::kMillisecond);

BENCHMARK_CAPTURE(BM_DisplayListBuiderWithScaleAndTranslate,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithScaleAndTranslate,
kDefault,
DisplayListBuilderBenchmarkType::kDefault)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithScaleAndTranslate,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithScaleAndTranslate,
kBounds,
DisplayListBuilderBenchmarkType::kBounds)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithScaleAndTranslate,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithScaleAndTranslate,
kRtree,
DisplayListBuilderBenchmarkType::kRtree)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithScaleAndTranslate,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithScaleAndTranslate,
kBoundsAndRtree,
DisplayListBuilderBenchmarkType::kBoundsAndRtree)
->Unit(benchmark::kMillisecond);

BENCHMARK_CAPTURE(BM_DisplayListBuiderWithPerspective,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithPerspective,
kDefault,
DisplayListBuilderBenchmarkType::kDefault)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithPerspective,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithPerspective,
kBounds,
DisplayListBuilderBenchmarkType::kBounds)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithPerspective,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithPerspective,
kRtree,
DisplayListBuilderBenchmarkType::kRtree)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithPerspective,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithPerspective,
kBoundsAndRtree,
DisplayListBuilderBenchmarkType::kBoundsAndRtree)
->Unit(benchmark::kMillisecond);

BENCHMARK_CAPTURE(BM_DisplayListBuiderWithClipRect,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithClipRect,
kDefault,
DisplayListBuilderBenchmarkType::kDefault)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithClipRect,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithClipRect,
kBounds,
DisplayListBuilderBenchmarkType::kBounds)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithClipRect,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithClipRect,
kRtree,
DisplayListBuilderBenchmarkType::kRtree)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithClipRect,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithClipRect,
kBoundsAndRtree,
DisplayListBuilderBenchmarkType::kBoundsAndRtree)
->Unit(benchmark::kMillisecond);

BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayer,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayer,
kDefault,
DisplayListBuilderBenchmarkType::kDefault)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayer,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayer,
kBounds,
DisplayListBuilderBenchmarkType::kBounds)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayer,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayer,
kRtree,
DisplayListBuilderBenchmarkType::kRtree)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayer,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayer,
kBoundsAndRtree,
DisplayListBuilderBenchmarkType::kBoundsAndRtree)
->Unit(benchmark::kMillisecond);

BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayerAndImageFilter,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayerAndImageFilter,
kDefault,
DisplayListBuilderBenchmarkType::kDefault)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayerAndImageFilter,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayerAndImageFilter,
kBounds,
DisplayListBuilderBenchmarkType::kBounds)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayerAndImageFilter,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayerAndImageFilter,
kRtree,
DisplayListBuilderBenchmarkType::kRtree)
->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayerAndImageFilter,
BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayerAndImageFilter,
kBoundsAndRtree,
DisplayListBuilderBenchmarkType::kBoundsAndRtree)
->Unit(benchmark::kMillisecond);
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/flutter/platform_view_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class PlatformViewBuilder {
// Once Build is called, the instance is no longer usable.
GfxPlatformView Build() {
EXPECT_FALSE(std::exchange(built_, true))
<< "Build() was already called, this buider is good for one use only.";
<< "Build() was already called, this builder is good for one use only.";
return GfxPlatformView(
delegate_, task_runners_, std::move(view_ref_pair_.view_ref),
external_external_view_embedder_, std::move(ime_service_),
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/flutter/tests/flatland_platform_view_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ class PlatformViewBuilder {
// Once Build is called, the instance is no longer usable.
FlatlandPlatformView Build() {
EXPECT_FALSE(std::exchange(built_, true))
<< "Build() was already called, this buider is good for one use only.";
<< "Build() was already called, this builder is good for one use only.";
return FlatlandPlatformView(
delegate_, task_runners_, std::move(view_ref_pair_.view_ref),
external_external_view_embedder_, std::move(ime_service_),
Expand Down