This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Omit NOP rendering operation which is outside of the clip bounds #35024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on flutter/flutter#100172, we can treat ops out of the clip bounds as NOPs and omit them
For details, see how the following submission handles
clipRect.As you can see, some tests fail with this optimization.
display_list_rendertests:
engine/display_list/display_list_canvas_unittests.cc
Lines 1860 to 1864 in 56c6c18
failed log
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8807250199871484161/+/u/test:_Host_Tests_for_host_profile/stdout?format=raw
display_list_unittests (if ignore failed tests in display_list_rendertests):
engine/display_list/display_list_unittests.cc
Line 207 in 56c6c18
failed log
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8807249085090327521/+/u/test:_Host_Tests_for_host_profile/stdout?format=raw
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.