Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix source blend #34066

Merged
merged 1 commit into from
Jun 15, 2022
Merged

[Impeller] Fix source blend #34066

merged 1 commit into from
Jun 15, 2022

Conversation

bdero
Copy link
Member

@bdero bdero commented Jun 15, 2022

Fixes flutter/flutter#105945.

We had an alpha compositing issue going on in DirectionalGaussianBlur which turned out to be an extra alpha factor lingering in the Source blend mode.

I added some input options to the GaussianBlurFilter playground to repro the issue.

Screen.Recording.2022-06-15.at.1.03.53.AM.mov

@bdero bdero requested review from chinmaygarde and dnfield June 15, 2022 08:20
@bdero bdero merged commit 1c22a58 into flutter:main Jun 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
9340a37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
e53d658
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
d6b9fd8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
981d431
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
2441fcd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
0e0c67a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
f739967
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
94246c4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
a6fcb76
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
38c123c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
45700c2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
fb7b01b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
9c66965
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
55cf19a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
acc6565
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
c9a5faf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
5297fcc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
5a86bfd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
f1eb4bc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
1c22a58 Fix source blend (flutter/engine#34066)
b503b07
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@bdero @houhuayong
Fix source blend (flutter#34066)
3b1e7dc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects: engine e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] DirectionalGaussianBlur isn't handling alpha correctly

2 participants

@bdero @chinmaygarde