Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Mar 14, 2022

Re-lands PR #31092, with the following differences:

  1. Leaves usages of DEFAULT_SYSTEM_UI flag due to change in edge-to-edge mode becoming the Android standard after API 29 and the undesired effects of using the updated backwards compatible API, which caused a regression.*
  2. Suppresses deprecation warnings for the PlatformPlugin methods and DEFAULT_SYSTEM_UI flag usages where deprecated APIs cannot be completely removed.

*Ultimately, a migration to use these APIs should be made to streamline behavior across Android versions (see related issue).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@camsim99 camsim99 marked this pull request as ready for review May 26, 2022 22:29
@camsim99 camsim99 requested review from Piinks and blasten May 27, 2022 16:30
@camsim99 camsim99 marked this pull request as draft May 31, 2022 21:43
@camsim99 camsim99 closed this Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant