Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Mar 4, 2022

Add the newly added Finalizer and NativeFinalizer patch files to all the Flutter patch file lists.

This ensures we can land VM recognized classes in those patch files in the face of version skew in G3.

Prior art:

Does not add the files to golden in this PR, because the auto-roller already did that.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@mraleph
Copy link
Member

mraleph commented Mar 4, 2022

LGTM

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zanderso zanderso deleted the vm-finalizer-patch-files branch March 4, 2022 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants