Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove unused Counter and CounterValues class. #31130

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Remove unused Counter and CounterValues class. #31130

merged 1 commit into from
Jan 29, 2022

Conversation

@eggfly
Copy link
Member

@eggfly eggfly commented Jan 28, 2022 •
edited
Loading

I checked in git blame and found that the Counter and CounterValues class in instrumentation.h are they are not actually used anymore since 2016. So I think we can remove them.

The Visualize() method is duplicated between the Counter and Stopwatch class, and the Counter is not used anymore, so I think the Counter can be removed.

And no tests are written because it's only a code removal. cc @Hixie ～

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

dnfield
dnfield approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm pending test exemption

@Hixie
Copy link
Contributor

Hixie commented Jan 28, 2022

test-exempt: only code removal

You may be interested in adjusting the bot in the flutter/cocoon repo to not say anything for patches that only involve code removal; it's already implemented that way for other flutter repos and it's fine to enable it for engine too.

@eggfly
Copy link
Member Author

eggfly commented Jan 29, 2022

test-exempt: only code removal

You may be interested in adjusting the bot in the flutter/cocoon repo to not say anything for patches that only involve code removal; it's already implemented that way for other flutter repos and it's fine to enable it for engine too.

Nice! How to enable it into engine?

@eggfly eggfly added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 29, 2022
@fluttergithubbot fluttergithubbot merged commit 4b55492 into flutter:main Jan 29, 2022
@Hixie
Copy link
Contributor

Hixie commented Jan 29, 2022

looks like it's in https://github.com/flutter/cocoon/blob/main/app_dart/lib/src/request_handlers/github_webhook.dart

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2022
@engine-flutter-autoroll
4b55492 Remove unused Counter and CounterValues class. (flutter/engin…
202216f 
…e#31130)
godofredoc pushed a commit to flutter/flutter that referenced this pull request Jan 29, 2022
@engine-flutter-autoroll
Roll Engine from 2d3663c to 4b55492 (4 revisions) (#97463)
33ffb27 
* 7b26f7a Roll Skia from 32f7fa7bfef3 to c4ba48a7d8c3 (2 revisions) (flutter/engine#31139)

* 312551e Revert "Revert engine (#31135)" (flutter/engine#31142)

* e17ee4a Add constexpr endianness utilities to fml (flutter/engine#31118)

* 4b55492 Remove unused Counter and CounterValues class. (flutter/engine#31130)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll @clocksmith
Roll Engine from 2d3663c to 4b55492 (4 revisions) (flutter#97463)
d715390 
* 7b26f7a Roll Skia from 32f7fa7bfef3 to c4ba48a7d8c3 (2 revisions) (flutter/engine#31139)

* 312551e Revert "Revert engine (flutter#31135)" (flutter/engine#31142)

* e17ee4a Add constexpr endianness utilities to fml (flutter/engine#31118)

* 4b55492 Remove unused Counter and CounterValues class. (flutter/engine#31130)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

@Hixie Hixie Awaiting requested review from Hixie

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eggfly @Hixie @dnfield @fluttergithubbot