This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add option to enable serial GC #30975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
rmacnak-google
approved these changes
Jan 25, 2022
zanderso
reviewed
Jan 25, 2022
shell/common/switches.h
Outdated
| "with assertions disabled in the debug product mode (i.e. with JIT " | ||
| "or DBC).") | ||
| DEF_SWITCH(EnableSerialGC, | ||
| "enable_serial_gc", |
There was a problem hiding this comment.
It looks like the style in this file is to use '-' rather than '_' to separate the words in a flag.
Suggested change
| "enable_serial_gc", | |
| "enable-serial-gc", |
testing/dart/serial_gc_test.dart
Outdated
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| // FlutterTesterOptions=--serial_gc |
There was a problem hiding this comment.
Does this need to be --enable-serial-gc?
testing/dart/serial_gc_test.dart
Outdated
| @@ -0,0 +1,17 @@ | |||
| // Copyright 2022 The Flutter Authors. All rights reserved. | |||
There was a problem hiding this comment.
Flutter keeps 2013 as the copyright year for all files.
Suggested change
| // Copyright 2022 The Flutter Authors. All rights reserved. | |
| // Copyright 2013 The Flutter Authors. All rights reserved. |
This commit is empty and simply triggers a new build to open the tree. Commit 106963e was re-built after a succesful build; upload to the cloud storage bin failed.
This option can be used to avoid thread contention issues for the UI thread when running on low power devices with limited number of cores.
zanderso
approved these changes
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option can be used to avoid thread contention issues for the UI thread when running on low power devices with limited number of cores.