Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jan 19, 2022

Although the Win32 keyboard logic correctly ignores IME key events from letter keys (identified by virtual key VK_PROCESSKEY), it didn't handle modifier keys during IME mode well, which is a result of two mistakes:

  1. It incorrectly synthesizes a key down event, since the key state is set, while the virtual key is not the usual virtual key for the modifier.
  2. It incorrectly dispatches a non-synthesized key down event if the extended bit is set, because result_logical_key will not be 0xe5 but with an extended bit.

This PR fixes the first problem by moving the VK_PROCESSKEY branch to before modifier synthesization, and adding an exception rule to the logical key conversion. As a result, IME events will no longer trigger modifier synthesization at all. It's a little sad, but acceptable.

Fixes flutter/flutter#95888.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 19, 2022
@fluttergithubbot fluttergithubbot merged commit 40a06f5 into flutter:main Jan 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 20, 2022
itsjustkevin pushed a commit to itsjustkevin/engine that referenced this pull request Jan 24, 2022
itsjustkevin pushed a commit to itsjustkevin/engine that referenced this pull request Jan 25, 2022
@dkwingsmt dkwingsmt deleted the ime-modifiers branch February 23, 2022 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: text input platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows Desktop ] Pressing Right Ctrl key throws exception: A KeyUpEvent is dispatched, but the state shows that the physical key is pressed

3 participants