This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Win32, Keyboard] Correctly process modifier events in IME mode #30919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Although the Win32 keyboard logic correctly ignores IME key events from letter keys (identified by virtual key
VK_PROCESSKEY), it didn't handle modifier keys during IME mode well, which is a result of two mistakes:result_logical_keywill not be0xe5but with an extended bit.This PR fixes the first problem by moving the
VK_PROCESSKEYbranch to before modifier synthesization, and adding an exception rule to the logical key conversion. As a result, IME events will no longer trigger modifier synthesization at all. It's a little sad, but acceptable.Fixes flutter/flutter#95888.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.