This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow builder to skip building examples. #30917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently started building the examples in the `examples` directory. However, those examples use the GLFW dependency that not all embedders have. This broke their build. Those builder may now use `--build-embedder-examples` to avoid building the examples. Fixes flutter/flutter#95711
stuartmorgan-g
approved these changes
Jan 19, 2022
| help='Do not build the GLFW shell on platforms where it is built by default.') | ||
| parser.add_argument('--build-embedder-examples', action='store_const', const=True, | ||
| help='Build the example embedders using the Embedder API.') | ||
| parser.add_argument('--no-build-embedder-examples', dest='build_embedder_examples', action='store_const', const=False, |
Contributor
There was a problem hiding this comment.
Isn't the no version of a flag created automatically when it's a boolean?
Member
Author
There was a problem hiding this comment.
Good question. I just followed the example of the --no-build-glfw-shell flag above.
Member
Author
There was a problem hiding this comment.
Apparently, it isn't: error: unrecognized arguments: --no-build-embedder-examples when I remove it. Apparently, it is possible in Python 3.9 according to the internet. Leaving it as is.
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Jan 24, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Jan 25, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Jan 25, 2022
itsjustkevin
added a commit
that referenced
this pull request
Jan 25, 2022
…1034) * 'Update Dart SDK to ac38a9d' * Allow builder to skip building examples. (#30917) * 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml' * remove unnecessary ref to flutter candidate * updating license hash Co-authored-by: Kevin Chisholm <[email protected]> Co-authored-by: Chinmay Garde <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently started building the examples in the
examplesdirectory. However,those examples use the GLFW dependency that not all embedders have. This broke
their build. Those builder may now use
--build-embedder-examplesto avoidbuilding the examples.
Fixes flutter/flutter#95711