Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Win32, Keyboard] Migrate FlutterWindowWin32 keyboard tests to keyboard_win32_unittests #30808

Merged
merged 5 commits into from
Jan 12, 2022
Merged

[Win32, Keyboard] Migrate FlutterWindowWin32 keyboard tests to keyboard_win32_unittests #30808

merged 5 commits into from
Jan 12, 2022

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jan 12, 2022 •
edited
Loading

This PR migrated the keyboard tests in flutter_window_win32_unittests.cc to keyboard_win32_unittests.cc, while completing all 8 tests for 4 pairs of modifiers.

This PR fixed an issue where an AltRight tap at the beginning of the app startup might cause extra synthesized events, hence crashing the app.

This PR also removes some tests from keyboard_key_handler_unittests that have been migrated by #30615 or is no longer useful.

This is one of the many steps to refactor the windows keyboard system.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gspencergoog
gspencergoog approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt merged commit 73b1723 into flutter:main Jan 12, 2022
@dkwingsmt dkwingsmt deleted the win-key-move-window-tests-to-keyboard-unittest branch January 12, 2022 23:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2022
@engine-flutter-autoroll
73b1723 [Win32, Keyboard] Migrate FlutterWindowWin32 keyboard tests t…
eb092f4 
…o keyboard_win32_unittests (flutter/engine#30808)
JsouLiang pushed a commit to JsouLiang/engine that referenced this pull request Jan 14, 2022
@dkwingsmt @JsouLiang
[Win32, Keyboard] Migrate FlutterWindowWin32 keyboard tests to keyboa…
a003411 
…rd_win32_unittests (flutter#30808)

* Until AltLeft

* Alt right

* Meta keys

* Remove tests

* Format
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects: text input platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt @gspencergoog