Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Bump Robolectric to 4.7.3 #30437

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Bump Robolectric to 4.7.3 #30437

merged 2 commits into from
Jan 7, 2022

Conversation

@utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Dec 21, 2021

Bump Robolectric to latest 4.7.3 to support SDK 31.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@utzcoz
Copy link
Contributor Author

utzcoz commented Dec 21, 2021

Looks like there are some failed tests, and I will check it locally.

@utzcoz
Copy link
Contributor Author

utzcoz commented Dec 25, 2021

Looks like new Robolectic version will change the priority of getSystemService result between spy one and real one.

@utzcoz
Copy link
Contributor Author

utzcoz commented Dec 25, 2021 •
edited
Loading

If I add @Config(sdk = 30) to related tests, all tests passed. Looks like there are some things changed at SDK 31.

@utzcoz
Restrict SingleViewPresentationTest under SDK 31
ed64f71 
Looks like
https://android.googlesource.com/platform/frameworks/base/+/f3aefb28029f5eb05835a61e86bf660cc72da432%5E%21/core/java/android/app/Presentation.java
added at Android 12 breaks flutter's hook to cache IMM instance for
Presentation. Before it is fixed, we should restrict
SingleViewPresentationTest to ensure that it will not run with SDK 31 to
avoid failures.

Signed-off-by: utzcoz <[email protected]>
@utzcoz
Copy link
Contributor Author

utzcoz commented Dec 25, 2021

Looks like commit Migrate Presentation to WindowContext added at Android 12 breaks flutter's hook to cache IMM instance, created by #12085. The commit Migrate Presentation to WindowContext uses window Context created from display Context with createWindowContext method. The cached IMM isn't been passed to new WindowContext by ImmContext on Android 12. Hi @mklim, could you help to confirm whether this commit causes this problem(SingleViewPresentationTest failed on SDK 31)?

@utzcoz
Copy link
Contributor Author

utzcoz commented Jan 4, 2022

Hi @zanderso , could you help to look at this PR? Thanks.

@zanderso zanderso mentioned this pull request Jan 6, 2022
Closed
blasten
blasten approved these changes Jan 7, 2022
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 7, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 7, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 7, 2022
@zanderso zanderso added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 7, 2022
@fluttergithubbot fluttergithubbot merged commit 685d220 into flutter:main Jan 7, 2022
@utzcoz utzcoz deleted the bump-Robolectric-to-4.7.3 branch January 7, 2022 03:41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2022
@engine-flutter-autoroll
685d220 Bump Robolectric to 4.7.3 (flutter/engine#30437)
2484c27
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 7, 2022
@engine-flutter-autoroll
Roll Engine from 8498779 to 594238c (22 revisions) (#96268)
3e5ddff 
* 1f60bfc Fix missing shcore.dll error on Windows 7 (flutter/engine#30699)

* 4c30367 Roll Fuchsia Mac SDK from G04Sc3__F... to WjrtT4DAB... (flutter/engine#30700)

* 2bf6b01 Migrate keyboard_key_handler_unittests to keyboard_win32_unittests (flutter/engine#30615)

* ed6868f Update //third_party/glfw from Aug 2016 to Jan 2019 (revision 78e6a006) (flutter/engine#30609)

* 7fae72a Roll Skia from 88c5af7ecd72 to 8e6b60f27da3 (3 revisions) (flutter/engine#30703)

* b01a5a9 Roll Fuchsia Mac SDK from WjrtT4DAB... to fSRFvvC1c... (flutter/engine#30705)

* 63f9190 Roll Skia from 8e6b60f27da3 to f5853ff6525b (1 revision) (flutter/engine#30706)

* 7467eac Roll Skia from f5853ff6525b to db2b8eb98f14 (1 revision) (flutter/engine#30708)

* 936c3a0 Roll Skia from db2b8eb98f14 to 426f7b5ad606 (2 revisions) (flutter/engine#30710)

* 9524ec8 Roll Skia from 426f7b5ad606 to a5d4541ae556 (3 revisions) (flutter/engine#30712)

* e8bb686 Roll Skia from a5d4541ae556 to 96e4053be7a5 (3 revisions) (flutter/engine#30714)

* d301340 Roll Skia from 96e4053be7a5 to ce49ff6520fa (4 revisions) (flutter/engine#30715)

* 38a007d Roll Dart SDK from f59531cc2973 to 5f2c54513b7d (13 revisions) (flutter/engine#30716)

* 305dcd5 Roll Skia from ce49ff6520fa to 73657689b6cb (5 revisions) (flutter/engine#30718)

* d930dce [web] allow customizing Ahem URL using FontManifest.json (flutter/engine#30719)

* a0bbfeb Roll Skia from 73657689b6cb to 72412a86725a (3 revisions) (flutter/engine#30721)

* d53b3c2 Fix aot builds in the dart_runner for fuchsia (flutter/engine#30722)

* 56816a0 Roll Skia from 72412a86725a to 2f3891bf76f3 (1 revision) (flutter/engine#30723)

* 496e055 Roll Dart SDK from 5f2c54513b7d to 8a8fb0972646 (1 revision) (flutter/engine#30725)

* 685d220 Bump Robolectric to 4.7.3 (flutter/engine#30437)

* f8a8276 Roll Fuchsia Mac SDK from fSRFvvC1c... to cSwk_StnQ... (flutter/engine#30727)

* 594238c Revert Dart SDK to f59531cc2973 (flutter/engine#30729)
JsouLiang pushed a commit to JsouLiang/engine that referenced this pull request Jan 14, 2022
@utzcoz @JsouLiang
Bump Robolectric to 4.7.3 (flutter#30437)
2861f4d
@utzcoz
Copy link
Contributor Author

utzcoz commented Oct 7, 2022

Looks like commit Migrate Presentation to WindowContext added at Android 12 breaks flutter's hook to cache IMM instance, created by #12085. The commit Migrate Presentation to WindowContext uses window Context created from display Context with createWindowContext method. The cached IMM isn't been passed to new WindowContext by ImmContext on Android 12. Hi @mklim, could you help to confirm whether this commit causes this problem(SingleViewPresentationTest failed on SDK 31)?

Hi @chinmaygarde , could you help to find proper folk to check whether this problem still exist? Looks like IMM window context doesn't work on Android 12 still now(inspecting from testing result).

@zanderso
Copy link
Member

zanderso commented Oct 7, 2022

@chinmaygarde isn't the right person to look into that. Maybe @stuartmorgan or @GaryQian know whether this can be answered?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

2 more reviewers

@blasten blasten blasten approved these changes

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@utzcoz @fluttergithubbot @zanderso @blasten