This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Clarify ImageDescriptor.raw pixel order and add version detector
#30343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
dnfield
reviewed
Dec 16, 2021
lib/web_ui/test/html/image_test.dart
Outdated
| // current Web engine decodes pixel data. | ||
| // | ||
| // The HTML renderer uses the BMP format to display pixel data, but it used to | ||
| // uses a wrong implementation. The bug has been fixed, but the fix breaks apps |
dnfield
approved these changes
Dec 16, 2021
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
dkwingsmt
force-pushed
the
clarify-raw-image
branch
from
25dee62 to
19fb921
Compare
dkwingsmt
force-pushed
the
clarify-raw-image
branch
from
19fb921 to
9e9bed1
Compare
|
Gold has detected about 28 new digest(s) on patchset 5. |
dkwingsmt
added
affects: tests
waiting for tree to go green
3 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 24, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the documentation of
ImageDescriptor.rawanddecodeImageFromPixelson how their pixels are ordered. It also adds a test for a migration guide.This is to follow the discussion in flutter/flutter#93615 about the impact of the breakage introduced by #29593.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.