Support opacity layers for platform-views using hybrid-composition #30264

WasserEsser · 2021-12-10T05:40:55Z

SceneBuilder opacity layers are not currently supported for Android platform-views using hybrid-composition.
This PR implements it.

Note that even though #58426 mentions opacity being implemented, it does not seem to be the case.

Fixes #93757
Advances #58426

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the [CLA].
All existing and new tests are passing.

cyanglaz

LGTM on the mutator stack code.
I'm not confident enough to review the code related to android paint context.

CC @blasten as the second reviewer.

cyanglaz · 2021-12-13T18:46:36Z

shell/platform/android/io/flutter/embedding/engine/mutatorsstack/FlutterMutatorView.java

+    Paint transparency = new Paint();
+    transparency.setAlpha((int) (mutatorsStack.getFinalOpacity() * 255));
+    this.setLayerType(LAYER_TYPE_HARDWARE, transparency);


CC @blasten for confirming this is OK

does it need to create a new Paint object on every draw call? does this work?

In the constructor:

paint = new Paint(); setLayerType(LAYER_TYPE_HARDWARE, paint);

onDraw:

paint.setAlpha((int) (mutatorsStack.getFinalOpacity() * 255));

seems like this should work from looking at the android code, but please give it a try and confirm

@blasten You're right, we don't need to create the paint object on every draw call.
We do however need to set the layer type every time, moving it into the constructor does not seem to be enough.

I have updated the code regarding this

flutter-dashboard · 2022-01-12T18:32:30Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

WasserEsser · 2022-01-12T21:36:58Z

@cyanglaz @cbracken

I rebased it so the golden tests are up to date.

cyanglaz · 2022-01-13T18:06:00Z

@WasserEsser Which golden test are you talking about? Since the opacity is supported in this change, I suppose there should be an updated golden image in the scenario test (https://github.com/flutter/engine/tree/main/testing/scenario_app) in this PR. I didn't see an update on the golden image.

cyanglaz · 2022-01-13T18:06:17Z

adding @blasten for a 2nd review.

WasserEsser · 2022-01-13T18:08:21Z

@cyanglaz I was just referring to the comment the flutter bot made about the tests expiring as the PR is somewhat older.

cyanglaz · 2022-01-13T18:11:06Z

@WasserEsser Ok, so it is unrelated to what I said about the scenario tests then. Are you familiar with the scenario tests? There should be a README to help you set it up.

WasserEsser · 2022-01-13T18:30:45Z

@cyanglaz Yep, although I couldn't get them to run the last time I've tried. I'll try to create one later tonight.

chinmaygarde · 2022-01-20T21:21:54Z

@WasserEsser Any update on the test?

blasten

LGTM

blasten · 2022-01-20T22:10:59Z

The scenario app tests on Android are currently broken unfortunately. flutter/flutter#90401.

There's an opacity test already, but it won't fail because this test was disabled. https://github.com/flutter/engine/blob/main/testing/scenario_app/android/reports/screenshots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformViewOpacity.png

WasserEsser · 2022-01-20T22:18:47Z

@blasten Ah that's why I couldn't get them to work.

fluttergithubbot · 2022-01-20T22:40:08Z

This pull request is not suitable for automatic merging in its current state.

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

…ition (flutter/engine#30264)

…ition (#30264)" This reverts commit 730b469.

…ition" (#31002) * Revert "Support opacity layers for platform-views using hybrid-composition (#30264)" This reverts commit 730b469. * Empty

* Revert "Support opacity layers for platform-views using hybrid-composition" (#31002) * Revert "Support opacity layers for platform-views using hybrid-composition (#30264)" This reverts commit 730b469. * Empty * Revert "[fuchsia] Switch from core-jit to core snapshots. (#30744)" (#31065) This reverts commit a193f08. Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: David Worsham <[email protected]>

flutter-dashboard bot added the platform-android label Dec 10, 2021

WasserEsser force-pushed the b93757 branch from db16460 to 023f8bd Compare December 11, 2021 02:33

WasserEsser marked this pull request as ready for review December 11, 2021 21:46

cyanglaz self-requested a review December 12, 2021 17:19

WasserEsser mentioned this pull request Dec 13, 2021

SIGABRT on TimeToFirstNativeMessageFromIsolateInNewVM benchmark flutter/flutter#95064

Closed

cyanglaz reviewed Dec 13, 2021

View reviewed changes

WasserEsser added 3 commits January 12, 2022 21:55

Support opacity for platform views using hybrid composition

e024ec4

Use a hardware layer to avoid double filling

99c7c3b

Add tests

e78ac76

WasserEsser force-pushed the b93757 branch from 023f8bd to e78ac76 Compare January 12, 2022 20:57

cyanglaz requested a review from blasten January 13, 2022 18:03

WasserEsser added 2 commits January 13, 2022 20:43

Avoid construction of Paint object every draw call

091514d

Use this.paint

7770a6c

blasten approved these changes Jan 20, 2022

View reviewed changes

WasserEsser requested a review from cyanglaz January 20, 2022 22:18

blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 20, 2022

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 20, 2022

cyanglaz approved these changes Jan 20, 2022

View reviewed changes

cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 20, 2022

fluttergithubbot merged commit 730b469 into flutter:main Jan 20, 2022

engine-flutter-autoroll mentioned this pull request Jan 21, 2022

Roll Engine from cd65368f9dec to 0e3b9ff883fa (7 revisions) flutter/flutter#96970

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 21, 2022

730b469 Support opacity layers for platform-views using hybrid-compos…

ea086f2

…ition (flutter/engine#30264)

engine-flutter-autoroll mentioned this pull request Jan 21, 2022

Roll Engine from cd65368f9dec to f4f288b0a181 (8 revisions) flutter/flutter#96975

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 21, 2022

730b469 Support opacity layers for platform-views using hybrid-compos…

0dc3824

…ition (flutter/engine#30264)

engine-flutter-autoroll mentioned this pull request Jan 21, 2022

Roll Engine from cd65368f9dec to f785b798162d (10 revisions) flutter/flutter#96980

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 21, 2022

730b469 Support opacity layers for platform-views using hybrid-compos…

923c838

…ition (flutter/engine#30264)

zanderso mentioned this pull request Jan 23, 2022

Performance regression in raster times on android_view_scroll_perf__timeline_summary flutter/flutter#97079

Closed

zanderso added a commit that referenced this pull request Jan 23, 2022

Revert "Support opacity layers for platform-views using hybrid-compos…

6956a18

…ition (#30264)" This reverts commit 730b469.

zanderso mentioned this pull request Jan 23, 2022

Revert "Support opacity layers for platform-views using hybrid-composition" #31002

Merged

gmackall mentioned this pull request Feb 25, 2025

Implement opacity FlutterMutator for hcpp flutter/flutter#164147

Merged

9 tasks

Support opacity layers for platform-views using hybrid-composition #30264

Support opacity layers for platform-views using hybrid-composition #30264

Uh oh!

Conversation

WasserEsser commented Dec 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

cyanglaz Dec 13, 2021

Choose a reason for hiding this comment

Uh oh!

blasten Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

blasten Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

WasserEsser Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

WasserEsser Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Jan 12, 2022

Uh oh!

WasserEsser commented Jan 12, 2022

Uh oh!

cyanglaz commented Jan 13, 2022

Uh oh!

cyanglaz commented Jan 13, 2022

Uh oh!

WasserEsser commented Jan 13, 2022

Uh oh!

cyanglaz commented Jan 13, 2022

Uh oh!

WasserEsser commented Jan 13, 2022

Uh oh!

chinmaygarde commented Jan 20, 2022

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

blasten commented Jan 20, 2022

Uh oh!

WasserEsser commented Jan 20, 2022

Uh oh!

fluttergithubbot commented Jan 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WasserEsser commented Dec 10, 2021 •

edited

Loading