This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] expire ImageDecoder after inactivity; implement toByteData #30224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| late ui.VoidCallback callback; | ||
| /// | ||
| /// If this is null, the alarm goes off without calling the callback. Set the | ||
| /// callback to null of the callback is a closure holding onto expensive |
There was a problem hiding this comment.
Typo: /// callback to null -if- the callback is a closure holding onto expensive
|
|
||
| _cachedWebDecoder = webDecoder; | ||
|
|
||
| // Expire the decoder if it not used for several seconds. If the image is |
There was a problem hiding this comment.
Typo: // Expire the decoder if -it's- not used for several seconds. If the image is
| @override | ||
| late int repetitionCount; | ||
|
|
||
| /// Whether this decoded has been disposed of. |
There was a problem hiding this comment.
Typo: /// Whether this -decoder- has been disposed of.
mdebbar
approved these changes
Dec 9, 2021
| ..width = width | ||
| ..height = height; | ||
| final html.CanvasRenderingContext2D ctx = canvas.context2D; | ||
| drawVideoFrame(ctx, videoFrame, 0, 0); |
Contributor
There was a problem hiding this comment.
btw, you can do:
ctx.drawImage(videoFrame, 0, 0);but you probably have to make VideoFrame implements CanvasImageSource.
yjbanov
force-pushed
the
expire-image-decoder
branch
from
a5dce05 to
8c1225c
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageDecoderafter 3 seconds of inactivity (fixes [Web] Gridview with images has significant memory leak flutter#94500)toByteDatafor images decoded usingImageDecoder(this may be temporary https://bugs.chromium.org/p/skia/issues/detail?id=12721)