This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Teach gclient to run pub in more directories #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At gclient sync time, we now run `pub get` for every Dart package except `workbench`. This patch ensures that we have all the packages we need locally.
Contributor
|
lgtm |
abarth
added a commit
that referenced
this pull request
Jul 27, 2015
Teach gclient to run pub in more directories
miguelfrde
pushed a commit
to miguelfrde/engine
that referenced
this pull request
Jan 7, 2020
…flutter#302) To detect and rebuild all TUs on toolchain updates, we inherited a rule from Chromium whereby the Git SHA of the //buildtools repo would be used to insert a preprocessor define in each TUs build invocation. But we don't use a //buildtools as a repo anymore. Instead buildtools comes from CIPD. So the script now picks the //buildroot revision instead. But we don't specify the toolchain revision in that repo either though. It is instead specified in the engine. So if the engine updates the toolchain, only the next (unrelated) //buildroot rev will ensure all old TUs are rebuilt unless the `out` directory is cleared on each invocation. This patch replaces the old buggy technique with one where the system headers (that include headers in buildtools) are tracked in addition to user headers. When the toolchain updates, these "system" header timestamps will be invalidated and the old artifacts invalidate. The simple change of just tracking the //flutter (where the toolchain SHA is present) would make it so that each engine change (frequent) would rebuild all TUs instead of just each buildtools change (rarer). Also, this technique would leave us susceptible to the kind of issue that led us in this situation in the first place. I also just searched and replaced all calls to track user dependencies with ones to track system + user dependencies. Not all toolchain are actually being used. We should clean these up in a separate patch.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Fixes flutter#164 The primary syntax bug is a missing closing paren. This commit also fixes some style: - Use cascades in the sample code. - Use consistent single quotes in the sample code. - Use a blank line following the first sentence of all doc comments. - Delete some wholly redundant doc comments. - Rename a private constant to lower camel case.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Update CHANGELOG.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
It is a built-in-identifier with the new static extension methods.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At gclient sync time, we now run
pub getfor every Dart package exceptworkbench. This patch ensures that we have all the packages we need locally.