VSyncWaiter on Fuchsia will defer firing until frame start time (#29287) #30079
Conversation
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to fuchsia_f6. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
naudzghebre
force-pushed
the
fuchsia_f6
branch
from
d3e0804 to
f04a52c
Compare
| std::string prefix = "vsync_waiter_test"; | ||
|
|
||
| fml::MessageLoop::EnsureInitializedForCurrentThread(); | ||
| auto platform_task_runner = fml::MessageLoop::GetCurrent().GetTaskRunner(); |
There was a problem hiding this comment.
This test is failing because the the unit-tests don't always have a default task runner setup which makes GetCurrent unsafe. The way to fix this would be to create a thread (you are already using a thread host so add flutter::ThreadHost::Type::PLATFORM to it and and use its task runner). Please don't FML_USED_ON_EMBEDDER as that is may not work in all unit-test.
There was a problem hiding this comment.
Oh, ok. Disregard the latest push. Amended FML_USED_ON_EMBEDDER before seeing your comment.
There was a problem hiding this comment.
Yeah, that define is used by embedder platforms that depend on a default message loop already setup. The engine internals don't use that by default and we added the deprecation explicitly to trip accidentally calling the accessor instead of holding references to a task runner.
naudzghebre
force-pushed
the
fuchsia_f6
branch
2 times, most recently
from
4329f90 to
d4a69a5
Compare
…ter#29287) * VSyncWaiter on Fuchsia will defer firing until frame start time The common vsync waiter implementation expects this invariant to be held. * Add a test for vsync_waiter
naudzghebre
force-pushed
the
fuchsia_f6
branch
from
d4a69a5 to
ef567d1
Compare
4 participants
The common vsync waiter implementation expects this invariant to be
held.
Original bug: b/208443497
CP request: b/208711800