Update buildroot to pick up Xcode macOS SDK parsing #30066

jmagman · 2021-12-02T07:50:31Z

Roll buildroot to flutter/buildroot#528 and flutter/buildroot#530 and flutter/buildroot#531 so Xcode macOS SDKs are fetched from Xcode instead of path parsed.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2021-12-02T07:56:32Z

Well that didn't work:

2021-12-01 23:51:54.421 xcodebuild[48940:296760] [MT] DVTSDK: Skipped SDK /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.6.sdk; its version (13.6) is below required minimum (14.0) for the iphonesimulator platform.
2021-12-01 23:51:54.422 xcodebuild[48940:296760] [MT] DVTSDK: Skipped SDK /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.6.sdk; its version (13.6) is below required minimum (14.0) for the iphoneos platform.
Traceback (most recent call last):
  File "/opt/s/w/ir/cache/builder/src/build/mac/find_sdk.py", line 109, in <module>
    print((main()))
  File "/opt/s/w/ir/cache/builder/src/build/mac/find_sdk.py", line 79, in main
    raise Exception('No %s+ SDK found' % min_sdk_version)
Exception: No 10.12+ SDK found

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8828973834358097425/+/u/gn_--runtime-mode_profile_--android_--no-lto/stdout

jmagman · 2021-12-02T17:18:19Z

I'm not sure why, when I run with the same 12a7209 Xcode version locally, gn succeeds. The Xcode reported SDKs show macOS 10.5 and 11.1:

$ xcodebuild -showsdks -json
[
  {
    "buildID" : "6EA751FE-F279-11EA-A211-1B767842A7F0",
    "canonicalName" : "iphoneos14.0",
    "displayName" : "iOS 14.0",
    "isBaseSdk" : true,
    "platform" : "iphoneos",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/iPhoneOS.platform",
    "platformVersion" : "14.0",
    "productBuildVersion" : "18A390",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "iPhone OS",
    "productVersion" : "14.0",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk",
    "sdkVersion" : "14.0"
  },
  {
    "buildID" : "6EA751FE-F279-11EA-A211-1B767842A7F0",
    "canonicalName" : "iphonesimulator14.0",
    "displayName" : "Simulator - iOS 14.0",
    "isBaseSdk" : true,
    "platform" : "iphonesimulator",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/iPhoneSimulator.platform",
    "platformVersion" : "14.0",
    "productBuildVersion" : "18A390",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "iPhone OS",
    "productVersion" : "14.0",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.0.sdk",
    "sdkVersion" : "14.0"
  },
  {
    "canonicalName" : "driverkit.macosx19.0",
    "displayName" : "DriverKit 19.0",
    "isBaseSdk" : true,
    "platform" : "macosx",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/MacOSX.platform",
    "platformVersion" : "10.15.6",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/DriverKit19.0.sdk",
    "sdkVersion" : "19.0"
  },
  {
    "canonicalName" : "macosx10.15",
    "displayName" : "macOS 10.15",
    "iOSSupportVersion" : "13.6",
    "isBaseSdk" : true,
    "platform" : "macosx",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/MacOSX.platform",
    "platformVersion" : "10.15.6",
    "productBuildVersion" : "19G68",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "Mac OS X",
    "productUserVisibleVersion" : "10.15.6",
    "productVersion" : "10.15.6",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk",
    "sdkVersion" : "10.15.6"
  },
  {
    "canonicalName" : "macosx11.1",
    "displayName" : "macOS 11.1",
    "iOSSupportVersion" : "14.3",
    "isBaseSdk" : true,
    "platform" : "macosx",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/MacOSX.platform",
    "platformVersion" : "10.15.6",
    "productBuildVersion" : "20C63",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "macOS",
    "productUserVisibleVersion" : "11.1",
    "productVersion" : "11.1",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk",
    "sdkVersion" : "11.1"
  },
  {
    "buildID" : "FAE97D6E-F278-11EA-883F-E5155DA0F5D3",
    "canonicalName" : "appletvos14.0",
    "displayName" : "tvOS 14.0",
    "isBaseSdk" : true,
    "platform" : "appletvos",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/AppleTVOS.platform",
    "platformVersion" : "14.0",
    "productBuildVersion" : "18J390",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "Apple TVOS",
    "productVersion" : "14.0",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/SDKs/AppleTVOS14.0.sdk",
    "sdkVersion" : "14.0"
  },
  {
    "buildID" : "FAE97D6E-F278-11EA-883F-E5155DA0F5D3",
    "canonicalName" : "appletvsimulator14.0",
    "displayName" : "Simulator - tvOS 14.0",
    "isBaseSdk" : true,
    "platform" : "appletvsimulator",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/AppleTVSimulator.platform",
    "platformVersion" : "14.0",
    "productBuildVersion" : "18J390",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "Apple TVOS",
    "productVersion" : "14.0",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator14.0.sdk",
    "sdkVersion" : "14.0"
  },
  {
    "buildID" : "7A5435C4-ECE0-11EA-B282-A8CEEC67F544",
    "canonicalName" : "watchos7.0",
    "displayName" : "watchOS 7.0",
    "isBaseSdk" : true,
    "platform" : "watchos",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/WatchOS.platform",
    "platformVersion" : "7.0",
    "productBuildVersion" : "18R382",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "Watch OS",
    "productVersion" : "7.0",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/WatchOS.platform/Developer/SDKs/WatchOS7.0.sdk",
    "sdkVersion" : "7.0"
  },
  {
    "buildID" : "7A5435C4-ECE0-11EA-B282-A8CEEC67F544",
    "canonicalName" : "watchsimulator7.0",
    "displayName" : "Simulator - watchOS 7.0",
    "isBaseSdk" : true,
    "platform" : "watchsimulator",
    "platformPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/WatchSimulator.platform",
    "platformVersion" : "7.0",
    "productBuildVersion" : "18R382",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "Watch OS",
    "productVersion" : "7.0",
    "sdkPath" : "/Users/m/xcode-cipd/Xcode-12A7209.app/Contents/Developer/Platforms/WatchSimulator.platform/Developer/SDKs/WatchSimulator7.0.sdk",
    "sdkVersion" : "7.0"
  }
]

jmagman · 2021-12-02T17:51:53Z

xcode output on the builder is:

[
  {
    "buildID" : "6EA751FE-F279-11EA-A211-1B767842A7F0",
    "canonicalName" : "iphoneos14.0",
    "displayName" : "iOS 14.0",
    "isBaseSdk" : true,
    "platform" : "iphoneos",
    "platformPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform",
    "platformVersion" : "14.0",
    "productBuildVersion" : "18A390",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "iPhone OS",
    "productVersion" : "14.0",
    "sdkPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk",
    "sdkVersion" : "14.0"
  },
  {
    "buildID" : "6EA751FE-F279-11EA-A211-1B767842A7F0",
    "canonicalName" : "iphonesimulator14.0",
    "displayName" : "Simulator - iOS 14.0",
    "isBaseSdk" : true,
    "platform" : "iphonesimulator",
    "platformPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneSimulator.platform",
    "platformVersion" : "14.0",
    "productBuildVersion" : "18A390",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "iPhone OS",
    "productVersion" : "14.0",
    "sdkPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.0.sdk",
    "sdkVersion" : "14.0"
  },
  {
    "canonicalName" : "driverkit.macosx19.0",
    "displayName" : "DriverKit 19.0",
    "isBaseSdk" : true,
    "platform" : "macosx",
    "platformPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform",
    "platformVersion" : "10.15.6",
    "sdkPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/DriverKit19.0.sdk",
    "sdkVersion" : "19.0"
  },
  {
    "canonicalName" : "macosx10.15",
    "displayName" : "macOS 10.15",
    "iOSSupportVersion" : "13.6",
    "isBaseSdk" : true,
    "platform" : "macosx",
    "platformPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform",
    "platformVersion" : "10.15.6",
    "productBuildVersion" : "19G68",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "Mac OS X",
    "productUserVisibleVersion" : "10.15.6",
    "productVersion" : "10.15.6",
    "sdkPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk",
    "sdkVersion" : "10.15.6"
  },
  {
    "buildID" : "7A5435C4-ECE0-11EA-B282-A8CEEC67F544",
    "canonicalName" : "watchos7.0",
    "displayName" : "watchOS 7.0",
    "isBaseSdk" : true,
    "platform" : "watchos",
    "platformPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/WatchOS.platform",
    "platformVersion" : "7.0",
    "productBuildVersion" : "18R382",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "Watch OS",
    "productVersion" : "7.0",
    "sdkPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/WatchOS.platform/Developer/SDKs/WatchOS7.0.sdk",
    "sdkVersion" : "7.0"
  },
  {
    "buildID" : "7A5435C4-ECE0-11EA-B282-A8CEEC67F544",
    "canonicalName" : "watchsimulator7.0",
    "displayName" : "Simulator - watchOS 7.0",
    "isBaseSdk" : true,
    "platform" : "watchsimulator",
    "platformPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/WatchSimulator.platform",
    "platformVersion" : "7.0",
    "productBuildVersion" : "18R382",
    "productCopyright" : "1983-2020 Apple Inc.",
    "productName" : "Watch OS",
    "productVersion" : "7.0",
    "sdkPath" : "/opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/WatchSimulator.platform/Developer/SDKs/WatchSimulator7.0.sdk",
    "sdkVersion" : "7.0"
  }
]

jmagman · 2021-12-02T17:56:52Z

I guess I don't have exactly the same bundle locally, the productName is "productName" : "Mac OS X", and the script is looking for macOS.

jmagman · 2021-12-02T21:08:22Z

These commits were rolled as part of #30068.

Update buildroot to pick up Xcode macOS SDK parsing

c57e90d

jmagman self-assigned this Dec 2, 2021

google-cla bot added the cla: yes label Dec 2, 2021

jmagman mentioned this pull request Dec 2, 2021

Print Xcode output when macOS SDKs are not found flutter/buildroot#530

Merged

8 tasks

And print

a53cd40

Mac OSX

c9faa28

jmagman closed this Dec 2, 2021

jmagman deleted the buildroot-sdk branch December 2, 2021 21:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update buildroot to pick up Xcode macOS SDK parsing #30066

Update buildroot to pick up Xcode macOS SDK parsing #30066

Uh oh!

jmagman commented Dec 2, 2021 •

edited

Loading

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Update buildroot to pick up Xcode macOS SDK parsing #30066

Update buildroot to pick up Xcode macOS SDK parsing #30066

Uh oh!

Conversation

jmagman commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

jmagman commented Dec 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jmagman commented Dec 2, 2021 •

edited

Loading