Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

Reverts #29631

Was this meant to land? @a-siva

The roll to the framework is still failing after this roll on the dart fix issue.

@google-cla google-cla bot added the cla: yes label Nov 10, 2021
@zanderso
Copy link
Member Author

E.g. here flutter/flutter#93406

@a-siva
Copy link
Contributor

a-siva commented Nov 10, 2021

Reverts #29631

Was this meant to land? @a-siva

The roll to the framework is still failing after this roll on the dart fix issue.

Yes, I was trying to see if reverting just https://dart-review.googlesource.com/c/sdk/+/219285 would solve the problem
but looks like it does not, we would have to revert https://dart-review.googlesource.com/c/sdk/+/219126 also I guess

@zanderso zanderso merged commit 15eb4ab into master Nov 10, 2021
@zanderso zanderso deleted the revert-29631-dart-sdk-flutter-engine-567e160e-3fc7-4869-a666-622823127e29-1636508174 branch November 10, 2021 17:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants