Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Nov 3, 2021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Nov 3, 2021
@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@godofredoc godofredoc requested review from xster and zanderso November 3, 2021 19:14
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@godofredoc godofredoc merged commit c9bef42 into flutter:flutter-2.7-candidate.5 Nov 3, 2021
@godofredoc godofredoc deleted the flutter-2.7-candidate.5 branch November 3, 2021 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes embedder Related to the embedder API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants