Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Nov 1, 2021

Reverts #29435

Reverting back to 2.15.0-268.0.dev for November beta hash alignment.

@google-cla google-cla bot added the cla: yes label Nov 1, 2021
@zanderso zanderso requested review from a-siva and godofredoc November 1, 2021 15:19
@a-siva
Copy link
Contributor

a-siva commented Nov 1, 2021

@Zra is there a regression because of which we are doing this revert ?

@zanderso
Copy link
Member Author

zanderso commented Nov 1, 2021

@Zra is there a regression because of which we are doing this revert ?

No. The Engine just got ahead of the internal repo. The alternative is to block hash alignment for a day to wait for g3 to catch up. Looking at the commits in #29435, I didn't see anything that was needed for the November beta, but maybe I misread.

@a-siva
Copy link
Contributor

a-siva commented Nov 1, 2021

@Zra is there a regression because of which we are doing this revert ?

No. The Engine just got ahead of the internal repo. The alternative is to block hash alignment for a day to wait for g3 to catch up. Looking at the commits in #29435, I didn't see anything that was needed for the November beta, but maybe I misread.

Sounds good.

@zanderso zanderso added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 1, 2021
@fluttergithubbot fluttergithubbot merged commit 7cee46c into master Nov 1, 2021
@zanderso zanderso deleted the revert-29435-dart-sdk-flutter-engine-2a909237-1c77-4f44-885a-64e2450b8cd7-1635748544 branch November 1, 2021 16:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
cbracken pushed a commit to flutter/flutter that referenced this pull request Nov 1, 2021
* 9f3ca93 Roll Dart SDK from 3b11f88c96a5 to 976f160b547f (3 revisions) (flutter/engine#29435)

* 1eec8c1 Roll Dart SDK from 3b11f88c96a5 to 976f160b547f (3 revisions) (flutter/engine#29436)

* 9c5f5d2 Roll Skia from 88b36ad61e80 to 2d76d7760f80 (3 revisions) (flutter/engine#29437)

* 9c88e86 Roll Skia from 2d76d7760f80 to 259ad7844587 (1 revision) (flutter/engine#29438)

* 27a7d2d Roll Skia from 259ad7844587 to 39eccabdc3e4 (1 revision) (flutter/engine#29439)

* 7cee46c Revert "Roll Dart SDK from 3b11f88c96a5 to 976f160b547f (3 revisions)" (flutter/engine#29440)
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
* 9f3ca93 Roll Dart SDK from 3b11f88c96a5 to 976f160b547f (3 revisions) (flutter/engine#29435)

* 1eec8c1 Roll Dart SDK from 3b11f88c96a5 to 976f160b547f (3 revisions) (flutter/engine#29436)

* 9c5f5d2 Roll Skia from 88b36ad61e80 to 2d76d7760f80 (3 revisions) (flutter/engine#29437)

* 9c88e86 Roll Skia from 2d76d7760f80 to 259ad7844587 (1 revision) (flutter/engine#29438)

* 27a7d2d Roll Skia from 259ad7844587 to 39eccabdc3e4 (1 revision) (flutter/engine#29439)

* 7cee46c Revert "Roll Dart SDK from 3b11f88c96a5 to 976f160b547f (3 revisions)" (flutter/engine#29440)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants