Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@richkadel
Copy link
Contributor

@richkadel richkadel commented Oct 4, 2021

When this test was originally added to the flutter/engine repo, the CI
test would not work because the Fuchsia test environment (based on
fuchsia's "terminal" product type) did not appear to include the
hardware-display-controller-provider package.

That package was added to terminal in the fuchsia.git change at
fxrev.dev/587281 and once that modified version of the "terminal"-based
image is used by fuchsia/engine CI, assuming it was the last blocker,
hopefully the test will now pass in CI.

The test does pass when run from a development environment.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

When this test was originally added to the flutter/engine repo, the CI
test would not work because the Fuchsia test environment (based on
fuchsia's "terminal" product type) did not appear to include the
hardware-display-controller-provider package.

That package was added to terminal in the fuchsia.git change at
fxrev.dev/587281 and once that modified version of the "terminal"-based
image is used by fuchsia/engine CI, assuming it was the last blocker,
hopefully the test will now pass in CI.

The test does pass when run from a development environment.
@google-cla google-cla bot added the cla: yes label Oct 4, 2021
@zanderso zanderso requested a review from arbreng October 7, 2021 20:22
@arbreng arbreng marked this pull request as draft October 14, 2021 20:03
@CaseyHillers CaseyHillers changed the base branch from master to main November 15, 2021 18:15
@richkadel
Copy link
Contributor Author

Resolved in #29565 (woohoo!)

@richkadel richkadel closed this Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant